Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove payload formatters class components #6399

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Remove payload formatters class components #6399

merged 3 commits into from
Jul 18, 2023

Conversation

ryaplots
Copy link
Contributor

Summary

References #6376

Changes

  • Refactor Application payload formatters
  • Refactor Device payload formatters

Testing

e2e

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the c/console This is related to the Console label Jul 17, 2023
@ryaplots ryaplots added this to the v3.27.0 milestone Jul 17, 2023
@ryaplots ryaplots self-assigned this Jul 17, 2023
@github-actions github-actions bot added ui/web This is related to a web interface and removed c/console This is related to the Console labels Jul 17, 2023
kschiffer
kschiffer approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my small remark.

pkg/webui/console/containers/application-payload-formatters/downlink.js Outdated Show resolved Hide resolved
pkg/webui/console/containers/application-payload-formatters/uplink.js Outdated Show resolved Hide resolved
pkg/webui/console/containers/device-payload-formatters/downlink.js Outdated Show resolved Hide resolved
@ryaplots ryaplots merged commit 61247c4 into v3.27 Jul 18, 2023
@ryaplots ryaplots deleted the fix/payload-formatters-class-components branch July 18, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschiffer kschiffer kschiffer approved these changes

@mjamescompton mjamescompton Awaiting requested review from mjamescompton mjamescompton is a code owner

Assignees

@ryaplots ryaplots

Labels
ui/web This is related to a web interface
Projects
None yet
Milestone
v3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryaplots @kschiffer