Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MQTT and Device Overview class components #6398

Merged
merged 7 commits into from
Jul 18, 2023
Merged

Remove MQTT and Device Overview class components #6398

merged 7 commits into from
Jul 18, 2023

Conversation

ryaplots
Copy link
Contributor

Summary

References #6376

Changes

  • Refactor Application MQTT integration
  • Refactor device overview view

Testing

e2e and manually

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added c/console This is related to the Console ui/web This is related to a web interface labels Jul 17, 2023
@ryaplots ryaplots added this to the v3.27.0 milestone Jul 17, 2023
@ryaplots ryaplots requested a review from kschiffer as a code owner July 17, 2023 09:16
@ryaplots ryaplots self-assigned this Jul 17, 2023
@github-actions github-actions bot removed the c/console This is related to the Console label Jul 17, 2023
@ryaplots
Copy link
Contributor Author

Also working on other components at the moment. So more PRs to come. I decided that several small PRs with refactoring might be easier to review than one huge PR.

@ryaplots ryaplots merged commit 37c6bf1 into v3.27 Jul 18, 2023
@ryaplots ryaplots deleted the fix/class-components branch July 18, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschiffer kschiffer kschiffer approved these changes

@mjamescompton mjamescompton Awaiting requested review from mjamescompton mjamescompton is a code owner

Assignees

@ryaplots ryaplots

Labels
ui/web This is related to a web interface
Projects
None yet
Milestone
v3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryaplots @kschiffer