Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing last seen value #6389

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix missing last seen value #6389

merged 1 commit into from
Jul 10, 2023

Conversation

kschiffer
Copy link
Contributor

Summary

This fixes a regression from #6327 where the last seen information is missing in end device tables.

Changes

  • Reintroduce the last_seen values into the status object

Testing

Manual testing.

Notes for Reviewers

I'll make a PR in enterprise as well.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to txe compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added bug Something isn't working c/console This is related to the Console ui/web This is related to a web interface labels Jul 10, 2023
@kschiffer kschiffer added this to the v3.27.0 milestone Jul 10, 2023
@kschiffer kschiffer self-assigned this Jul 10, 2023
@github-actions github-actions bot removed the c/console This is related to the Console label Jul 10, 2023
@kschiffer kschiffer merged commit 43cac0a into v3.27 Jul 10, 2023
@kschiffer kschiffer deleted the fix/end-device-list-last-seen branch July 10, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryaplots ryaplots ryaplots approved these changes

@mjamescompton mjamescompton Awaiting requested review from mjamescompton mjamescompton is a code owner

Assignees

@kschiffer kschiffer

Labels
bug Something isn't working ui/web This is related to a web interface
Projects
None yet
Milestone
v3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kschiffer @ryaplots