Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use the NS peer as a label #6344

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

adriansmares
Copy link
Contributor

Summary

This PR reduces the cardinality of two AS metrics which use the NS peer as the label. The peer name is not relevant and inconsistent (it mixes peer address with peer name).

Changes

  • Remove the network_server label for the received uplinks and forwarded downlinks.

Testing

🐒

Regressions

We do not use these labels in our aggregations, so there shouldn't be any regressions.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.26.2 milestone Jun 28, 2023
@adriansmares adriansmares self-assigned this Jun 28, 2023
@adriansmares adriansmares marked this pull request as ready for review June 28, 2023 17:31
@github-actions github-actions bot added the c/application server This is related to the Application Server label Jun 28, 2023
@adriansmares adriansmares merged commit d9237f3 into v3.26 Jun 29, 2023
5 of 6 checks passed
@adriansmares adriansmares deleted the fix/as-metrics-cardinality branch June 29, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/application server This is related to the Application Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants