Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces
github.com/grpc-ecosystem/go-grpc-prometheus
withgithub.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus
, as the former is deprecated and no longer receives updates.Changes
github.com/grpc-ecosystem/go-grpc-prometheus
withgithub.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus
.Testing
Local testing - there are no known metrics changes, but the original repository is no longer maintained.
Regressions
N/A.
Notes for Reviewers
We should upgrade
github.com/grpc-ecosystem/go-grpc-middleware
to theirv2
once they have an official release. The migration guide is already available, and in general the only change that we need to take care of is the depreciation ofgrpc_ctxtags
. The rest of the changes are not affecting us.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.