Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EUI ordering in claiming #6336

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Fix EUI ordering in claiming #6336

merged 1 commit into from
Jun 22, 2023

Conversation

adriansmares
Copy link
Contributor

Summary

References #6321

Changes

  • Fix EUI ordering in EDCS.

Testing

Unit tests.

Regressions

N/A. This fixes a regression.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.26.2 milestone Jun 22, 2023
@adriansmares adriansmares self-assigned this Jun 22, 2023
@adriansmares adriansmares marked this pull request as ready for review June 22, 2023 09:10
KrishnaIyer
KrishnaIyer approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@adriansmares adriansmares merged commit 1b3f801 into v3.26 Jun 22, 2023
@adriansmares adriansmares deleted the fix/claim-eui-order branch June 22, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrishnaIyer KrishnaIyer KrishnaIyer approved these changes

@nicholaspcr nicholaspcr Awaiting requested review from nicholaspcr nicholaspcr is a code owner

Assignees

@adriansmares adriansmares

Labels
None yet
Projects
None yet
Milestone
v3.26.2
Development

Successfully merging this pull request may close these issues.
2 participants
@adriansmares @KrishnaIyer