Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix claiming issues in frontend #6335

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Fix claiming issues in frontend #6335

merged 2 commits into from
Jun 29, 2023

Conversation

kschiffer
Copy link
Contributor

Summary

This quickfix PR addresses some issues with device claiming in the Console and JS SDK.

Changes

  • Fix claim info request when claiming device (JS SDK)
  • Improve error messaging for failed device claims

Testing

Manual testing.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added bug Something isn't working c/console This is related to the Console c/sdk/js This is related to the JavaScript SDK ui/web This is related to a web interface labels Jun 22, 2023
@kschiffer kschiffer added this to the v3.26.2 milestone Jun 22, 2023
@kschiffer kschiffer self-assigned this Jun 22, 2023
@github-actions github-actions bot removed the c/console This is related to the Console label Jun 22, 2023
@johanstokking johanstokking mentioned this pull request Jun 23, 2023
Closed
4 tasks
@adriansmares adriansmares merged commit 0d33107 into v3.26 Jun 29, 2023
@adriansmares adriansmares deleted the fix/frontend-claiming branch June 29, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryaplots ryaplots ryaplots approved these changes

@adriansmares adriansmares adriansmares approved these changes

@mjamescompton mjamescompton Awaiting requested review from mjamescompton mjamescompton is a code owner

@johanstokking johanstokking Awaiting requested review from johanstokking

Assignees

@kschiffer kschiffer

Labels
bug Something isn't working c/sdk/js This is related to the JavaScript SDK ui/web This is related to a web interface
Projects
None yet
Milestone
v3.26.2
Development

Successfully merging this pull request may close these issues.
4 participants
@kschiffer @johanstokking @adriansmares @ryaplots