Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send DELETE payload as search parameters for delete requests in JS SDK #6333

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

kschiffer
Copy link
Contributor

Summary

Quickfix which ensures that payloads for DELETE requests are sent as search parameters in the JS SDK.

Changes

  • Add 'delete' as method where payloads are transformed to search parameters.

Testing

  • Manual testing

Notes for Reviewers

This also fixes an issue in the Console with deleting user invitations.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added bug Something isn't working c/sdk/js This is related to the JavaScript SDK labels Jun 18, 2023
@kschiffer kschiffer added this to the v3.26.2 milestone Jun 18, 2023
@kschiffer kschiffer self-assigned this Jun 18, 2023
@kschiffer kschiffer marked this pull request as ready for review June 18, 2023 10:23
CHANGELOG.md Outdated Show resolved Hide resolved
@kschiffer kschiffer merged commit 1c42207 into v3.26 Jun 27, 2023
@kschiffer kschiffer deleted the fix/js-sdk-delete-query branch June 27, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/sdk/js This is related to the JavaScript SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants