Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport end device batch deletion #6329

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Backport end device batch deletion #6329

merged 1 commit into from
Jul 6, 2023

Conversation

KrishnaIyer
Copy link
Member

@KrishnaIyer KrishnaIyer commented Jun 15, 2023 •
edited
Loading

Summary

This is a full backport of https://github.com/TheThingsIndustries/lorawan-stack/pull/3676 without the enterprise portion.

Changes

Testing

Relevant unit tests are also backported.

Regressions

This is new functionality.

Notes for Reviewers

See https://github.com/TheThingsIndustries/lorawan-stack/pull/3676 for details. This is just to make merging eaiser.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@KrishnaIyer KrishnaIyer added this to the v3.26.2 milestone Jun 15, 2023
@KrishnaIyer KrishnaIyer self-assigned this Jun 15, 2023
@github-actions github-actions bot added c/application server This is related to the Application Server c/identity server This is related to the Identity Server c/join server This is related to the Join Server c/network server This is related to the Network Server compat/api This could affect API compatibility compat/db This could affect Database compatibility ui/cli This is related to ttn-lw-cli labels Jun 15, 2023
@KrishnaIyer KrishnaIyer force-pushed the feature/3632-batch-delete-devices branch 4 times, most recently from 1a06a9a to 5b80a41 Compare June 19, 2023 08:35
@KrishnaIyer KrishnaIyer marked this pull request as ready for review June 19, 2023 09:23
@KrishnaIyer
Copy link
Member Author

@adriansmares/ @nicholaspcr: Can I get a quick ACK/sanity check on this backport? the changes are mostly the same as the enterprise PR.

@KrishnaIyer KrishnaIyer force-pushed the feature/3632-batch-delete-devices branch 4 times, most recently from 9753499 to e0c58c5 Compare June 29, 2023 07:34
@KrishnaIyer KrishnaIyer modified the milestones: v3.26.2, v3.27.0 Jun 30, 2023
@adriansmares adriansmares changed the base branch from v3.26 to v3.27 July 3, 2023 10:56
@KrishnaIyer KrishnaIyer force-pushed the feature/3632-batch-delete-devices branch 3 times, most recently from a984276 to 9713371 Compare July 6, 2023 14:30
@KrishnaIyer KrishnaIyer force-pushed the feature/3632-batch-delete-devices branch from 9713371 to c71db28 Compare July 6, 2023 15:16
@KrishnaIyer KrishnaIyer merged commit d1fb150 into v3.27 Jul 6, 2023
11 of 13 checks passed
@KrishnaIyer KrishnaIyer deleted the feature/3632-batch-delete-devices branch July 6, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholaspcr nicholaspcr nicholaspcr approved these changes

@adriansmares adriansmares adriansmares approved these changes

@johanstokking johanstokking Awaiting requested review from johanstokking johanstokking is a code owner

Assignees

@KrishnaIyer KrishnaIyer

Labels
c/application server This is related to the Application Server c/identity server This is related to the Identity Server c/join server This is related to the Join Server c/network server This is related to the Network Server compat/api This could affect API compatibility compat/db This could affect Database compatibility ui/cli This is related to ttn-lw-cli
Projects
None yet
Milestone
v3.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@KrishnaIyer @nicholaspcr @adriansmares