Add soil to the normalized message preview in the events view #6164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In TheThingsNetwork#6154 the new Soil object from the normalized payload schema was added to the Application Server. This commit shows that new object in the event view of the Console.
Remove FPort, data rate, SNR and RSSI from the preview of normalized uplink messages. This info clutters the UI and is redundant here since these values don't change between the normal uplink message and the normalized uplink. The user can continue to view this info at a glance in the correspondent uplink event or in the event details.
pablojimpas
requested review from
kschiffer,
ryaplots and
mjamescompton
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #5758
Follow-up to #6154
Changes
Testing
Regressions
Notes for Reviewers
I've decided to remove FPort, data rate, SNR and RSSI from the preview of normalized
uplink messages because these previews can get quite long and messy as the number of objects and properties in the normalized schema grows. I think that they are not critical info to have there either, because these values are the same that in the normal uplink message.
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.