Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join server dev nonce metrics reversed #7318

Open
1 of 6 tasks
onizmx opened this issue Sep 24, 2024 · 0 comments
Open
1 of 6 tasks

Join server dev nonce metrics reversed #7318

onizmx opened this issue Sep 24, 2024 · 0 comments
Labels
needs/triage We still need to triage this

Comments

@onizmx
Copy link
Contributor

onizmx commented Sep 24, 2024

Summary

Not sure if this has any production implication, but happened to step on observability.go and discovered:
registerDevNonceReuse is using jsMetrics.devNonce.tooSmall and
registerDevNonceTooSmall is using jsMetrics.devNonce.reuse

Steps to Reproduce

func registerDevNonceReuse(ctx context.Context, msg *ttnpb.JoinRequest) {

Current Result

Not sure, perhaps metrics are reversed?

Expected Result

registerDevNonceReuse should be jsMetrics.devNonce.reuse and
registerDevNonceTooSmall shoud be jsMetrics.devNonce.tooSmall

Relevant Logs

No response

URL

No response

Deployment

The Things Stack Open Source (self-hosted)

The Things Stack Version

3.28.0 but also checked the latest release

Client Name and Version

No response

Other Information

No response

Proposed Fix

registerDevNonceReuse should be jsMetrics.devNonce.reuse and
registerDevNonceTooSmall shoud be jsMetrics.devNonce.tooSmall

Contributing

  • I can help by doing more research.
  • I can help by implementing a fix after the proposal above is approved.
  • I can help by testing the fix before it's released.

Validation

Code of Conduct

@onizmx onizmx added the needs/triage We still need to triage this label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/triage We still need to triage this
Projects
None yet
Development

No branches or pull requests

1 participant