You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not sure if this has any production implication, but happened to step on observability.go and discovered:
registerDevNonceReuse is using jsMetrics.devNonce.tooSmall and
registerDevNonceTooSmall is using jsMetrics.devNonce.reuse
Summary
Not sure if this has any production implication, but happened to step on observability.go and discovered:
registerDevNonceReuse is using
jsMetrics.devNonce.tooSmall
andregisterDevNonceTooSmall is using
jsMetrics.devNonce.reuse
Steps to Reproduce
lorawan-stack/pkg/joinserver/observability.go
Line 132 in 94ea5fb
Current Result
Not sure, perhaps metrics are reversed?
Expected Result
registerDevNonceReuse should be
jsMetrics.devNonce.reuse
andregisterDevNonceTooSmall shoud be
jsMetrics.devNonce.tooSmall
Relevant Logs
No response
URL
No response
Deployment
The Things Stack Open Source (self-hosted)
The Things Stack Version
3.28.0 but also checked the latest release
Client Name and Version
No response
Other Information
No response
Proposed Fix
registerDevNonceReuse should be
jsMetrics.devNonce.reuse
andregisterDevNonceTooSmall shoud be
jsMetrics.devNonce.tooSmall
Contributing
Validation
Code of Conduct
The text was updated successfully, but these errors were encountered: