Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete cascade connection profiles when deleting user/organization #7238

Open
3 of 6 tasks
PavelJankoski opened this issue Aug 14, 2024 · 1 comment
Open
3 of 6 tasks
Assignees
Labels
c/identity server This is related to the Identity Server needs/api This needs API design / approval

Comments

@PavelJankoski
Copy link
Contributor

PavelJankoski commented Aug 14, 2024

Summary

The connection profiles are not deleted when the user/organization that created them is deleted.

Steps to Reproduce

  1. Create user.
  2. Create wifi/ethernet profile with that user.
  3. Delete the user.
  4. Create user with the same user-id.
  5. Fetch profiles for that user.

Current Result

The previously created profiles are there.

Expected Result

Profiles should be empty for that user-id.

Deployment

The Things Stack Open Source (self-hosted)

Contributing

  • I can help by doing more research.
  • I can help by implementing a fix after the proposal above is approved.
  • I can help by testing the fix before it's released.

Validation

Code of Conduct

@PavelJankoski PavelJankoski added the needs/triage We still need to triage this label Aug 14, 2024
@PavelJankoski PavelJankoski added this to the 2024 Q3 milestone Aug 14, 2024
@KrishnaIyer KrishnaIyer modified the milestones: 2024 Q3, v3.32.1 Aug 15, 2024
@KrishnaIyer KrishnaIyer added c/identity server This is related to the Identity Server and removed needs/triage We still need to triage this labels Aug 15, 2024
@KrishnaIyer KrishnaIyer modified the milestones: v3.32.1, v3.32.2 Sep 16, 2024
@johanstokking
Copy link
Member

This is actually quite hard.

We would need to distribute deleted entities from IS to components (like GCS) to purge their own data stores, including remote databases, via some form of notifications from IS to clusters.

This will be useful for AS, NS and JS as well to clean up stuff.

I'm moving this out of the version milestone because this requires quite some work.

@johanstokking johanstokking added needs/api This needs API design / approval needs/discussion We need to discuss this labels Oct 10, 2024
@KrishnaIyer KrishnaIyer removed this from the v3.32.2 milestone Oct 11, 2024
@KrishnaIyer KrishnaIyer removed the needs/discussion We need to discuss this label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/identity server This is related to the Identity Server needs/api This needs API design / approval
Projects
None yet
Development

No branches or pull requests

3 participants