Refactor Network Server end device registry Set method validation #6732
Labels
c/network server
This is related to the Network Server
technical debt
Not necessarily broken, but could be done better/cleaner
Milestone
Summary
References https://github.com/TheThingsIndustries/lorawan-stack/pull/3850#issuecomment-1789261038
We should refactor the Network Server
NsEndDeviceRegistry.Set
validation logic in order to make it easier to maintain and review.Current Situation
The
Set
RPC works using field mask paths towards two end devices - the end device in the update request, and the end device which is stored. This makes the logic hard to validate and asses, and adds a lot of complexity to an RPC which is not called very often.Why do we need this? Who uses it, and when?
In order to be able to actually check the correctness of the RPC, and ensure that we really correctly validate requests.
Proposed Implementation
Contributing
Code of Conduct
The text was updated successfully, but these errors were encountered: