Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement accidental navigation prompt in payload formatter views #6384

Closed
4 tasks done
kschiffer opened this issue Jul 6, 2023 · 0 comments · Fixed by #6413
Closed
4 tasks done

Reimplement accidental navigation prompt in payload formatter views #6384

kschiffer opened this issue Jul 6, 2023 · 0 comments · Fixed by #6413
Assignees
Labels
c/console This is related to the Console technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface
Milestone

Comments

@kschiffer
Copy link
Member

Summary

Due to updates applied in #6327, we had to remove accidental navigation protection for the time being. This should be reimplemented soon.

Current Situation

When the user accidentally navigates away from the payload formatter form while entering a payload formatter, the Console will navigate away and all progress will be lost.

Why do we need this? Who uses it, and when?

We need to add a prompt that makes the user confirm the navigation so that accidental navigation can be prevented.

Proposed Implementation

I have to look at ways to implement prompting with the new react-router v6. From some initial research, it doesn't appear that straight forward.

Contributing

  • I can help by doing more research.
  • I can help by implementing the feature after the proposal above is approved.
  • I can help by testing the feature before it's released.

Code of Conduct

@kschiffer kschiffer added c/console This is related to the Console technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface needs/triage We still need to triage this labels Jul 6, 2023
@kschiffer kschiffer self-assigned this Jul 6, 2023
@johanstokking johanstokking assigned ryaplots and unassigned kschiffer Jul 19, 2023
@johanstokking johanstokking added this to the v3.27.1 milestone Jul 19, 2023
@johanstokking johanstokking removed the needs/triage We still need to triage this label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants