From e24deaea9be2436c7b78616c134e9a884ea967a6 Mon Sep 17 00:00:00 2001 From: Kevin Schiffer Date: Wed, 30 Aug 2023 12:56:08 +0800 Subject: [PATCH] dev: Update SDK todo comment --- sdk/js/src/service/devices/merge.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sdk/js/src/service/devices/merge.js b/sdk/js/src/service/devices/merge.js index 540b8c0638..808a721a06 100644 --- a/sdk/js/src/service/devices/merge.js +++ b/sdk/js/src/service/devices/merge.js @@ -65,7 +65,9 @@ export default (parts, base = {}, minimum = [['ids'], ['created_at'], ['updated_ } if (this.isLeaf) { - // TODO: Remove this once https://github.com/TheThingsNetwork/lorawan-stack/issues/4766 is resolved. + // TODO: Instead of ignoring empty time values, the merge order should be improved + // as described in the following issue comment: + // https://github.com/TheThingsNetwork/lorawan-stack/issues/4766#issuecomment-952691708 if (this.key.endsWith('_at') && e === '0001-01-01T00:00:00Z') { return }