From 707adb79184d4a6bca72af6cd0aa72c7ade7ab97 Mon Sep 17 00:00:00 2001 From: Darya Plotnytska Date: Thu, 10 Oct 2024 10:10:15 +0200 Subject: [PATCH 1/2] js: Fix reuse and tooSmall functions --- pkg/joinserver/observability.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/joinserver/observability.go b/pkg/joinserver/observability.go index f927b032cf..093a20984a 100644 --- a/pkg/joinserver/observability.go +++ b/pkg/joinserver/observability.go @@ -130,9 +130,9 @@ func registerRejectJoin(ctx context.Context, req *ttnpb.JoinRequest, err error) } func registerDevNonceReuse(ctx context.Context, msg *ttnpb.JoinRequest) { - jsMetrics.devNonce.tooSmall.WithLabelValues(ctx, ttnpb.MACVersion_name[int32(msg.SelectedMacVersion)]).Inc() + jsMetrics.devNonce.reuse.WithLabelValues(ctx, ttnpb.MACVersion_name[int32(msg.SelectedMacVersion)]).Inc() } func registerDevNonceTooSmall(ctx context.Context, msg *ttnpb.JoinRequest) { - jsMetrics.devNonce.reuse.WithLabelValues(ctx, ttnpb.MACVersion_name[int32(msg.SelectedMacVersion)]).Inc() + jsMetrics.devNonce.tooSmall.WithLabelValues(ctx, ttnpb.MACVersion_name[int32(msg.SelectedMacVersion)]).Inc() } From 12629bd4952a39138f7942550577aed63f6c5613 Mon Sep 17 00:00:00 2001 From: Darya Plotnytska Date: Thu, 10 Oct 2024 10:39:59 +0200 Subject: [PATCH 2/2] dev: Update CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 06c5870f5b..d0bbed6b6d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,7 @@ For details about compatibility between different releases, see the **Commitment ### Fixed - Potential leak of end devices of other (owned) applications in the top end devices panel in the application overview of the Console. +- Fix reversed Join Server dev nonce metrics. ### Security