-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tag dropdown menu #680
Conversation
Added some code that does a few things:
|
@LDannijs great by vendor is great, there are +/- 120 vendors, do you think adding more dropdowns can be good, as profiles (people can look US, AS, EU devices), thinking in the complete parameters that all devices should contain to be merged. |
@Jaime-Trinidad can you think of all the filter we can apply and list them here please? With their options |
@LDannijs so just a general one for PR's assignees should be you. And then reviewers should be anyone you want to look at it |
So i could add more filters, i am now working on one that filters through the different frequency plans for example, but i will not be able to have it dynamically change the page depending on what filters you select OR select multiple tags (as @pierrephz noted to me), since Hugo is a static framework. If i could get some guidelines on what the plan is here i could iterate on it further. |
Oh understood, i'll change that. |
Yes agree, is it possible to add more than one dropdown? the one on vendorID is good, and I think other ones can be good for making some filters, I think only from the mandate parameters, i.e. sensors is not mandatory so many devices don't have which sensor have. Here is a list of other possible dropdowns:
This are mandatory parameters for the validation, so all of them will contain this ones, at least VendorId and Profiles will be great for the moment. |
Pages like tags, vendors etc already have specific pages for strong for SEO. So we should separate idea between filtering the page data or going to a collection page. So next steps for this would be
So take what items are already on each page and filter them further. You never make a server requests to get more items. |
This goes a bit above my head, so if anything needs to change on that regard i would like some guidance. |
Before going to development, here is a prototype with filter feature. This is open for discussion I also think the UI and especially the cards need a new design (see my clip) device-repo-tag-feature.movI also did work on the dedicated device page, I can share it in another issue |
@pierrephz it would be very nice to if we have some kind of device repository statistics in the hero section. Amount of devices for instance, and device profiles. |
Let's incorporate this as part of #697 |
Summary
Add a dropdown menu that lists all the tags added to devices.
Changes
Notes for Reviewers
@mjamescompton @kschiffer @ryaplots please give this a look and make/note the necessary changes to it. This is my first time trying Hugo so it can definitely be improved.