-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2 new Elvaco devices #657
Merged
Jaime-Trinidad
merged 10 commits into
TheThingsNetwork:master
from
rgarmyn:elvaco_devices
Feb 28, 2024
Merged
Add 2 new Elvaco devices #657
Jaime-Trinidad
merged 10 commits into
TheThingsNetwork:master
from
rgarmyn:elvaco_devices
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @rgarmyn there is an error due the missing file of |
Hi Jaime, thanks for the review, it should work now. |
Jaime-Trinidad
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds support for the Elvaco vendor and two new payload decoders for the CMi4110 and CMi4140 devices.
Changes
Notes for Reviewers
The implementation of the payload decoders follows the specifications provided by Elvaco user guide. The decoders have been tested on limited amount of samples.
Release Notes