Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Normalized payload #400

Conversation

pablojimpas
Copy link
Contributor

Summary

First steps for implementing #395

Changes

  • Added uplinkNormalizer (similar to the previous uplinkDecoder)
  • Started work on the new normalizedPayload schema, for now just with common quantities and sensor.

Notes for Reviewers

  • This is just a work in progress draft, needs input and comments from all the interested parties.
  • I'm not very familiar with JSON schemas nor the lorawan stack in general, so be aware.
  • Some lines not relevant to this PR were reformatted by my editor, I did run npm run format but it didn't make a difference.

Release Notes

  • Added the field normalizedPayload to standardize quantities and units, it is optionally created by the function uplinkNormalizer as an extra step in the decoding pipeline.

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should target https://github.com/lorawan-schema/draft-devices/blob/master/schema.json (the file in this repository is a git submodule or a subtree)

Please do not use your editor's default code styler for formatting. You can use prettier if it respects .prettierrc in the project root.

lib/draft/schema.json Show resolved Hide resolved
@johanstokking
Copy link
Member

I'll close this PR. Please mention me in a PR in lorawan-schema account.

@pablojimpas
Copy link
Contributor Author

This PR should target https://github.com/lorawan-schema/draft-devices/blob/master/schema.json (the file in this repository is a git submodule or a subtree)

Aaah I missed that :(

I'll close this PR. Please mention me in a PR in lorawan-schema account.

Perfect, I'll open a similar PR there soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants