Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind marks to branch option #616

Open
JoelLau opened this issue Jul 8, 2024 · 1 comment
Open

bind marks to branch option #616

JoelLau opened this issue Jul 8, 2024 · 1 comment

Comments

@JoelLau
Copy link

JoelLau commented Jul 8, 2024

What issue are you having that you need harpoon to solve?
context: working in a monorepo, different set of files based on what ticket / project / branch i'm working on
idea: use a different set of marks based on git branch

Why doesn't the current config help?

What proposed api changes are you suggesting?

(close if not helpful)

@appleseedexm
Copy link

appleseedexm commented Jul 23, 2024

AFAIR this was a default on v1, but on v2 you'd need to provide a custom key function in your harpoon settings. A quick inspiration I could find in another thread: #565 (comment)

However #565 is currently a bug that will not re-open the correct custom key, so even with a modified key you'll lose your list on re-opening a specific branch.

IMO it would make sense to provide some branch-based examples in the readme since this was a default in v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants