Fix menu boxes in TD being too small #995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazelnot
force-pushed
the
boxfix
branch
5 times, most recently
from
5b59dca
to
559c637
Compare
|
#1000 is al alternative fix to this which is a less invasive change. After investigation it looks to me as though it is an issue with how the original DDraw path and the new SDL paths treat the clipping rect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the menu boxes being one pixel too short vertically and horizontally, as well as the small gaps in the TD DOS sidebar.
Fixes #993 and partially #756
(Thanks to @mvdhout1992 for actually fixing the code, I just implemented it)