drt: functions changed to have more explicit output #5778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bernardo <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
requested changes
Sep 19, 2024
Signed-off-by: bernardo <[email protected]>
|
I'm satisfied but want to leave a chance for @osamahammad21 to comment before merging. |
|
clang-tidy review says "All clean, LGTM! 👍" |
osamahammad21
approved these changes
Sep 19, 2024
| @@ -69,21 +69,21 @@ class UniqueInsts | |||
| void setDesign(frDesign* design) { design_ = design; } | |||
|
|
|||
| private: | |||
| using LayerRange = std::tuple<frLayerNum, frLayerNum>; | |||
| using LayerRange = std::pair<frLayerNum, frLayerNum>; | |||
| using MasterLayerRange = std::map<frMaster*, LayerRange, frBlockObjectComp>; | |||
There was a problem hiding this comment.
Use frBlockObjectMap instead, not necessary in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contain minor changes to some functions in PA. Functions changed take a reference to a container and fill said container. This PR changes it so instead it returns it.
This makes the functions role easier to understand, as its more obvious that its role is to return that structure and that it is an output, not an input.
This should not affect performance as due to move semantics instead of copying the returned structure its ownership is transferred to the caller.
Some functions have name changes:
prepPoint_pin_mergePinShapes→mergePinShapes(Conform to PR #5770)initMaster2PinLayerRange→initMasterToPinLayerRangeAlso
LayerRangewas changed to a pair instead of a tuple, as its always a tuple of 2 elements. This does not affect its use in code as it is accessed usingauto [a, b] = LayerRange.