Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpl2: Add C++ test for pushMacrosToCoreBoundaries #5373

Closed
wants to merge 42 commits into from
Closed

mpl2: Add C++ test for pushMacrosToCoreBoundaries #5373

wants to merge 42 commits into from

Conversation

amuritna
Copy link
Contributor

@amuritna amuritna commented Jul 12, 2024 •
edited
Loading

Added 2 C++ tests:

  1. ConstructedCentralizedMacros: Construct a Pusher object using a Cluster that would be detected as a design that has a "single centralized macro array" by Pusher, and check that the program doesn't halt.
  2. PushSimpleCluster: Construct a parent cluster made of two child clusters, each consisting of a macro. Run pushMacrosToCoreBoundaries and check that the two macros have been properly pushed to the boundaries.

@maliberty @vvbandeira @AcKoucher

@amuritna
mpl2: Some code comments/notes on hier_rtlmp.h
1b62981 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: initial progress for CanSnapMacros test
ed93fcd 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: instantiate dbbox, dbtechlayer objects
c77a435 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: set manufacturing grid on TestSnapper
8d3251b 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: instantiate 3 instances in TestSnapper
f58d671 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: refactor TestSnapper
e9b1102 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: reconfigure ODB set-up for CanSnapMacros
0731756 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: Try new testcases for CanSnapMacros
998d8f9 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: Configure CanSnapMacros testcases for horizontal dir
dd2a477 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: Add CanSnapMacros testcases for vertical dir
a0d11e4 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: Revert a commit that should've been commited to another branch.
5660662 
Signed-off-by: Emmanuella Rumanti <[email protected]>

This reverts commit 1b62981.
@amuritna
mpl2: Remove no longer used log messages
35a7a05 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: attempt to resolve git conflicts
c2969ab 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
Merge branch 'The-OpenROAD-Project:master' into mpl2-tests-2
690fb7f
@amuritna
mpl2: re-run clang-format for TestSnapper
08f63bd 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
Merge branch 'mpl2-tests-2' of https://github.com/amuritna/OpenROAD i…
06538a6 
…nto mpl2-tests-2
@amuritna
Merge branch 'The-OpenROAD-Project:master' into mpl2-tests-2
ec0a327
@amuritna
mpl2: Remove unnecessary code
a582b25 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: Remove trailing whitespace
9fa777b 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: Add helper.cpp and refactor
a2f3247 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: Re-run clang-format on TestSnapper
0bac6c5 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: correct TestSnapper variable names
1c98b38 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: Edit comments
36e8da2 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: Fix indentation
f86e6d7 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
Merge branch 'The-OpenROAD-Project:master' into mpl2-tests-2
11b63dd
@amuritna
mpl2: restructure CanSnapMacros into 2 unit tests
970b752 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: Add new helper function
f2f9beb 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: add SnapMacrosDouble
01f5840 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: clang formatting whitespace
e67517e 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: clang formatting indentation
9e7b35a 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: Minor changes to setup, naming
8eddb5f 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: reorganize mpin instantiation, comments
51c4d8f 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: listen to clang-tidy
7cbe946 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: minor [performance-unnecessary-value-param] fixes
a3bda9d 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: create ConstructPusherHardMacro
50c87fa 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: remove unnecessary code
1a99971 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: create ConstructedCentralizedMacros test
de2b153 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: progress on PushSimpleCluster
8547a36 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: create PushSimpleCluster
8e124e5 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: Finish initial PushSimpleCluster
57b0a00 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@amuritna
mpl2: Minor formatting edits
69b76d9 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@amuritna
mpl2: Remove unused code
04f292a 
Signed-off-by: Emmanuella Rumanti <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty maliberty closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amuritna @maliberty