Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer Alert Volume allows invalid values #6

Open
zeekrey opened this issue Apr 18, 2023 · 1 comment
Open

Timer Alert Volume allows invalid values #6

zeekrey opened this issue Apr 18, 2023 · 1 comment

Comments

@zeekrey
Copy link

zeekrey commented Apr 18, 2023

Hey hey 👋🏻

awesome raycast extension - keep it up! 🫶🏻

A tiny thing I've noticed: In the settings the alert volumne tooltip says values between 0 and 1 are allowed. But I can enter other values. I checked the raycast docs and couldn't find anything about preferences validation. Maybe there are other ways to achieve this.

@ThatNerdSquared
Copy link
Owner

Hey @zeekrey, thanks for using Timers!

You're right that's there's no real way for me to validate the preference - I do have a command runtime check to make sure the volume isn't set too high but it's quite strange because of the way afplay's volume settings work. You can check out this issue for more on that.

I'm currently working on solutions to this - both on making the volume setting more intuitive for the end user as well as adding proper checks for the volume (probably at runtime, unless the Raycast team adds a way for me to validate prefs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants