Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: fix Markdown link click behaviour #5223

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lowekoz
Copy link

@lowekoz lowekoz commented Nov 9, 2024

Running examples\markdown.py and clicking the example.md from the demo app will also open the relative file link ./example.md in the browser, which is a bit wonky behaviour. Relates to #5171 #5169, suggested fix by separating behaviour of external link protocols (http://,https://,ftp://...) and local resource path/anchor. With fix links won't trigger the browser open_url command, only external links will (if open_links=True), and external links won't trigger local navigation changes.

On approval TODOs:

  • Docstrings on all new or modified functions / classes
  • Updated documentation(?)
  • Updated CHANGELOG.md (where appropriate)
  • Tests (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant