-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New render protocol #5197
Open
willmcgugan
wants to merge
49
commits into
main
Choose a base branch
from
content
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New render protocol #5197
+21,615
−19,890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new system for rendering content. Previously Textual uses Rich Renderables.
Now we have a
textual.visual.Visual
which is a replacement for the renderable protocol, which allows for layered alpha colors via theContent
class.This is backwards compatible in that Textual you can still return a renderable via the
render()
method, which will be wrapped in atextual.visual.RichVisual
class.This is a large change, but only the OptionList actively uses Visuals currently.
In the future, there will be a Visual markup language, like console markup, but supporting alpha transparency and CSS variables. For instance, you could do this:
We don't have that yet, and there are still gaps in functionality, so this will remain undocumented for now.