Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed regular expressions for improving performance #3848

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eukub
Copy link

@eukub eukub commented Dec 11, 2023

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@rodrigogiraoserrao
Copy link
Contributor

rodrigogiraoserrao commented Dec 13, 2023

Hey there, thanks for your PR!

If your change improved performance, can you share the benchmark(s) you ran / by how much did performance improve?

Also, if I'm reading the docs correctly, \w is only equivalent to [a-zA-Z0-9_] if we use the flag re.ASCII and it doesn't look like we are, right?

@rodrigogiraoserrao
Copy link
Contributor

I was looking around and your PR might be a good idea, not from the point of view of performance, but to allow Unicode characters in class names, CSS IDs, variables, etc.
We won't push this forward right now because we want to consider the possible ramifications of making this change carefully.

We'll get back to you!

@eukub
Copy link
Author

eukub commented Dec 13, 2023

I was looking around and your PR might be a good idea, not from the point of view of performance, but to allow Unicode characters in class names, CSS IDs, variables, etc. We won't push this forward right now because we want to consider the possible ramifications of making this change carefully.

We'll get back to you!

Great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants