Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link update #1

Open
TeslaOwnerTips opened this issue Jun 20, 2024 · 9 comments
Open

Link update #1

TeslaOwnerTips opened this issue Jun 20, 2024 · 9 comments
Labels
question Further information is requested

Comments

@TeslaOwnerTips
Copy link
Contributor

Describe Your Problem:

I suggest updating the link in the image to point to git hub issues. It currently has a place holder link.

IMG_8495

Logs:

Show the Homebridge logs here, remove any sensitive information.

Plugin Config:

Show your Homebridge config.json here, remove any sensitive information.

Screenshots:

Environment:

  • Plugin Version:
  • Homebridge Version:
  • Node.js Version:
  • NPM Version:
  • Operating System:
@TeslaOwnerTips TeslaOwnerTips added the question Further information is requested label Jun 20, 2024
@Bre77
Copy link
Contributor

Bre77 commented Jun 20, 2024

The Report An Issue button takes me to https://github.com/teslemetry/homebridge/issues
Please update to the latest version (if not already) and check again.

@TeslaOwnerTips
Copy link
Contributor Author

Still the same
IMG_8506
IMG_8507

@Bre77
Copy link
Contributor

Bre77 commented Jun 21, 2024

That looks like the correct link then, Teslemetry is building the Homebridge integration for both Teslemetry and Tessie, so that is the correct page. Where were you expecting it to take you?

@TeslaOwnerTips
Copy link
Contributor Author

TeslaOwnerTips commented Jun 21, 2024

This is and will be confusing. I have never used a homebridge plugin that does not use a git hub repository with its own name to report bugs.
So usually
git hub link/developer/homebridge-tessie

The Read Me for above then has information similar to this
https://www.npmjs.com/package/homebridge-tessie

@Bre77
Copy link
Contributor

Bre77 commented Jun 21, 2024

I have an idea on how to address this, I'll ensure the home page goes to the right branch (which has the branded readme) and the new issue link goes to an appropriate issue template take makes it clear which service is being used.

I intend to keep using a single repo since over 95% of the code is identical between them, and so I can keep them both maintained in lockstep.

@TeslaOwnerTips
Copy link
Contributor Author

I appreciate all your hard work.

@TeslaOwnerTips
Copy link
Contributor Author

If I submit documentation pull requests that could be common to both branches do I submit them to the dev branch?

Most of the documentation will probably be the same with two options when it comes to specific platforms being used. This will reduce documentation overhead.

In the common documentation we could make it clear how to submit issues specific to the platform in use.

Do you want to start a wiki or do you want one large readme file?

@Bre77
Copy link
Contributor

Bre77 commented Jun 25, 2024

I had not considered contributions yet. Documentation for both go to dev, and specific documentation goes to the respective branch. I'll take your PR and implement it.

@TeslaOwnerTips
Copy link
Contributor Author

I’m not strong on github use so I’m not sure what to do with your edit. I didn’t see any approve/accept options. I just responded okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants