Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLb description for generated messages? #43

Open
bminaiev opened this issue Oct 24, 2022 · 3 comments
Open

Add TLb description for generated messages? #43

bminaiev opened this issue Oct 24, 2022 · 3 comments

Comments

@bminaiev
Copy link
Contributor

Maybe also add a TLb description of all messages, which contracts could generate and send to external contracts?

For example, at the end of the auction, nft-item sends an ownership_assigned message to a new owner, but it is not clear what is the format of the message. E.g. what does .store_int(0, 1) mean in that query? And why bidder_address is stored in that message (they probably already know their address)? Should it be prev_owner instead (similar to nft_answer_ownership_assigned)?

@arseny30
Copy link
Collaborator

ownership_assigned is from TEP 62
But yes, it makes sense to include its description in the schema.

@bminaiev
Copy link
Contributor Author

Hmm, if it is ownership_assigned from TEP 62, then it is a bug, that bidder_address is stored there, not owner? Am I missing something?

@bminaiev
Copy link
Contributor Author

Made a PR in case this is indeed a bug: #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants