Don't build Cairo with LZO #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-malburg
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Code looks good.
Dave tested this on Mac and it looked good.
I tried testing on Windows locally, but ran into some issues locally. This is, however, working in the context of this PR: #3
Latest build for Windows: https://dev.azure.com/techsmith/ThirdParty-vcpkg-build-GTK/_build/results?buildId=247952&view=logs&jobId=25bedee7-8114-508e-6fa2-082e8abf6738&j=25bedee7-8114-508e-6fa2-082e8abf6738&t=7124f712-a60a-5415-25d8-c65ad71c221e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want Cairo to be built with LZO because LZO is a GPL library.
This PR modifies the Cairo port such that: