Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The user-contributed sm_amazon_dns example has many die() statements and is not returning PEAR errors #3

Open
danbrenner opened this issue Oct 11, 2016 · 0 comments

Comments

@danbrenner
Copy link
Contributor

For example:

https://github.com/TeamUbersmith/service_modules/blob/master/sm_amazon_dns/class.sm_amazon_dns.php#L314

Ubersmith Inc. didn't write this example, but we should probably correct it - however, I've never used/tested this module and I'm not aware of its history. The print() statements instead of returning PEAR errors are incorrect, and there should never be die() statements in this code.

@danbrenner danbrenner changed the title The user-contributed Amazon example has many die() statements and is not returning PEAR errors The user-contributed sm_amazon_dns example has many die() statements and is not returning PEAR errors Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant