Feature: Mark as Watched button in Feed #1581
Conversation
- Separate watchHistory and hideWatched preferences. - Create db when hideWatched is on but watchHistory is off. - Add english translations.
…into feature-add-seen
|
Wouldn't it be better to use an icon, e.g. an eye for the button instead of using plain text? |
|
I feel we also need a new three-dot menu for playlist actions and this since otherwise, the UI is going to get cluttered. |
|
Thanks for the feedback! Gonna work on this a bit more soon.
Not sure what you mean, this was styled with a Font Awesome eye icon to match the listen and add to playlist buttons. |
Oh, sorry, my bad, I just saw you added translation strings for it and just wondered if an icon wouldn't be better in that case, didn't see you already use one ;) |
|
Ah! The translation strings were just for titles! |
|
Resolved the merge conflict. Looking forward to a new round of feedback. |
|
Apologies for the long hiatus! I have resolved the conflicts of this PR, hoping we can finish it off! |
| if (this.item.watched) { | ||
| let request = store.delete(videoId); | ||
| request.onsuccess = function () { | ||
| instance.$emit("update:watched", [instance.item.url]); | ||
| }; | ||
| return; | ||
| } |
There was a problem hiding this comment.
If we delete the item, then updateWatched won't really update the watched property if someone marks a video as unwatched. So, the video will still show up as watched until they reload the page.
|
Coming from invidious I only miss this one feature strongly. There is no other way to clean up your feed without this button and it has really helped me to get rid of FOMO, so please consider merging this PR! |
|
I still believe this feature is crucial to Piped but I do not have the bandwidth to continue development. Is there anyone who would like to take up the mantle? |
This PR adds a button next to the Listen and Add to Playlist buttons on feed.
Addresses at least part of #1512.