Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate build to version catalogs #11684

Open
wants to merge 21 commits into
base: refactor
Choose a base branch
from

Conversation

JL0000
Copy link

@JL0000 JL0000 commented Nov 8, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Moved project dependencies from build files to a version catalog file.

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/large PRs with less than 750 changed lines label Nov 8, 2024
@opusforlife2 opusforlife2 added codequality Improvements to the codebase to improve the code quality rewrite Issues and PRs related to rewrite labels Nov 8, 2024
@TobiGr TobiGr mentioned this pull request Nov 9, 2024
Copy link

sonarcloud bot commented Nov 9, 2024

@Stypox
Copy link
Member

Stypox commented Nov 10, 2024

Thanks for the PR! This should go to the refactor branch though, as the dev branch is kind of in maintenance mode. You can change the base branch by clicking "Edit" next to the PR title.

@JL0000 JL0000 changed the base branch from dev to refactor November 10, 2024 15:05
Thompson3142 and others added 21 commits November 10, 2024 15:35
Fixed crashes from recycled bitmaps by creating real copies of bitmaps if necessary + some minor refactoring
* IcePick fails on Java 21 (default in Android Studio 2024.2)
* Bridge is the most modern alternative that is currently available. It is backed by ``Android-State`` and can be configured with various frameworks
* In the long term this should be replaced with something better
Co-authored-by: Tobi <[email protected]>
Null-safe alternative to SharedPreferences.getString that guarantees the return value is non-null when defValue is non-null.
@github-actions github-actions bot added the size/giant PRs with more than 750 changed lines label Nov 10, 2024
@github-actions github-actions bot removed the size/large PRs with less than 750 changed lines label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality rewrite Issues and PRs related to rewrite size/giant PRs with more than 750 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate project dependencies to using Version Catalogs
9 participants