[Bug] Sever Reconnect #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comeheredart
requested review from
inddoni,
HJinhee,
hryeong66,
hwangJi-dev and
parkikbum
hryeong66
reviewed
Mar 7, 2022
Comment on lines
+19
to
+21
| let lastID: Int | ||
| let lastCount: Int | ||
| let drive: [DriveElement] |
There was a problem hiding this comment.
p2;
์ ํฌ ID๋ Id๋ก ๋ง์ด ์จ์
lastId๋ก ๋ฐ๊พธ๊ณ condingkeys๋ฅผ ๋ฃ๋๊ฒ ์ด๋จ๊น์?
Comment on lines
+92
to
+93
| var tags = [element.region, element.theme, | ||
| element.warning ?? ""] as [String] |
There was a problem hiding this comment.
p4;
์ด ๋ถ๋ถ DriveElement model ์ชฝ์์ ํจ์๋ฅผ ๋ง๋ค์ด์ ์ฌ์ฉํ๋ ๊ฒ๋ ๊ด์ฐฎ์ ๊ฒ ๊ฐ์์!
DriveElement ์ฝ๋ ์ชฝ์์
func getTagTextList() โ [String]{
return [element.region, element.theme, element.warning ?? ""]
}
Comment on lines
+96
to
+101
| cell.setData(image: element.image, | ||
| title: element.title, | ||
| tagCount: tags.count, | ||
| tagArr: tags, | ||
| isFavorite: element.drive[indexPath.row].isFavorite, | ||
| postID: element.drive[indexPath.row].postID) | ||
| isFavorite: element.isFavorite, | ||
| postID: element.postID) |
There was a problem hiding this comment.
p4;
ํน์ ์ด ๋ถ๋ถ์ ํ๋ผ๋ฏธํฐ๋ก element๋ฅผ ๋๊ฒจ์ฃผ๊ณ ์ฒ๋ฆฌํ๋๊ฑด ์ด๋จ๊น์?
inddoni
approved these changes
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ ๊ด๋ จ ์ด์
closed: #177
๐ ๋ณ๊ฒฝ ์ฌํญ ๋ฐ ์ด์
ํ ๋ง ์๋ฒ๋ฅผ ์ฌ์ฐ๊ฒฐ ํ์ต๋๋น!
๐ PR Point
์ต๋ฒ์จ ์ฐธ๊ณ ํ์ธ์ฉ!
๐ ์ฐธ๊ณ ์ฌํญ