Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA] Fix mix of TcVersions #731

Open
rruiter87 opened this issue Jun 19, 2024 · 2 comments
Open

[IDEA] Fix mix of TcVersions #731

rruiter87 opened this issue Jun 19, 2024 · 2 comments

Comments

@rruiter87
Copy link
Collaborator

When I open the TcOpen main solution file, I get many warnings popping up about different TwinCAT versions that are not installed on my system.

image

Here is a screenshot of several versions. I'm not sure what the best course of action is to prevent all these pop-ups. Maybe through a pre-commit hook?

image

@PTKu
Copy link
Member

PTKu commented Jun 19, 2024

Yeah, this is a major annoyance. @rruiter87, would you be so kind as to have a look at the pre-commit hook? If it's somewhat easy to take, you can do it. Please get in touch with @peterbarancek if you need some support. I am not sure, but I think the build script does some modifications to tsproj files already to align with versions... that might also be the way.

@rruiter87
Copy link
Collaborator Author

Yeah, I can take a look at the pre-commit hooks. If we decide to go that way, I want to add it to the existing TwinCAT pre-commits, if the maintainers agree.

In your build scripts, it only removes a pinned version if present:

RemovePinVersion($tsProject)

Since this is in the build script, a pinned version can still be present in the committed code.

A pre-commit would anyway be nice, then I can also include the STweep formatting for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants