Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patrimoine script is broken #18

Open
benbel opened this issue Nov 17, 2017 · 3 comments
Open

Patrimoine script is broken #18

benbel opened this issue Nov 17, 2017 · 3 comments
Assignees
Labels

Comments

@benbel
Copy link
Contributor

benbel commented Nov 17, 2017

To be more precise, TIL-Core matching does not or no longer works with the Patrimoine data used by TIL-France.

  return func(*args, **kwargs)
Traceback (most recent call last):
  File "til_init.py", line 269, in <module>
    sys.exit(main())
  File "til_init.py", line 263, in main
    exit_value = task()
  File "til_init.py", line 206, in build_patrimoine_data
    patrimoine()
  File "c:\users\b.belrhomari\z\til\til-france\til_france\data\data\Patrimoine.py", line 1008, in test_build
    data.matching_par_enf()
  File "c:\users\b.belrhomari\z\til\til-france\til_france\data\data\Patrimoine.py", line 805, in matching_par_enf
    method='cells'
  File "c:\users\b.belrhomari\z\til\til-core\til_core\data\utils\matching.py", line 202, in evaluate
    assert match.nunique() == len(match)
AssertionError
@benbel
Copy link
Contributor Author

benbel commented Nov 21, 2017

Some precisions for @benjello: running Patrimoine.py on Patrimoine data used to work without problem, and the matching part no longer works. Patrimoine data has not changed (I checked with the very same files that used to work), hence the problem is most likely to come from TIL-France.

The only change that to Patrimoine.py was this commit, which must have broken something.

I will check if using older versions of OSM/TIL-Core/Til-France works, and then we can start working from there.

Work on all in one initialization script for TIL France is frozen until this issue is settled.

@benjello
Copy link
Member

Thanks @benbel . The changes followed warnings/deprecations from pandas.
I will look into that ASAP.

@benbel
Copy link
Contributor Author

benbel commented Nov 22, 2017

Patrimoine.py as of this commit ie before the big changes to Patrimoine.py does not work either, though it must have worked at some point. Likely to be caused by a change in one of the dependencies.

@benbel benbel mentioned this issue Mar 26, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants