Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gevent #6

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove gevent #6

wants to merge 1 commit into from

Commits on Dec 9, 2015

  1. Remove dependency on gevent. At least judging from the source code in… 

    … this repository, it seems it is not needed. In fact, the current implementation fails to forward messages received from the server to a callback registered via `some_hub.client.on('method', callback)`. The reason for this is that the listener which polls for incoming messages is spawned via gevent.spawn(listener), but (at least in the source code of this repository) no other method such as gevent.joinall() is ever called. This results in the listener never actually running. The new proposed implementation uses standard Python threads instead and fixes the problem that messages received from the server are not processed.
    @mherrmann
    mherrmann committed Dec 9, 2015
    Configuration menu
    Copy the full SHA
    77a8925 View commit details
    Browse the repository at this point in the history