-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TDS-7385/esm): fix module not found error for @talend/react-bootstrap and @talend/icons #5340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trap and @talend/icons
hbhong
temporarily deployed
to
pull_request_unsafe
June 14, 2024 07:45
— with
GitHub Actions
Inactive
hbhong
temporarily deployed
to
pull_request_unsafe
June 14, 2024 07:45
— with
GitHub Actions
Inactive
hbhong
temporarily deployed
to
pull_request_unsafe
June 14, 2024 07:45
— with
GitHub Actions
Inactive
Size Change: 0 B Total Size: 16.9 MB ℹ️ View Unchanged
|
mhuchet
approved these changes
Jun 14, 2024
yyanwang
approved these changes
Jun 14, 2024
lmaillet
approved these changes
Jun 14, 2024
hbhong
had a problem deploying
to
pull_request_unsafe
June 14, 2024 08:22
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
After running
postinstall
on ui-ee, there is nolib-esm
folder for@talend/react-bootstrap
and@talend/icons
packages, this causesModule not found
error when running upgrade dependencieshttps://jira.talendforge.org/browse/TDS-7385
What is the chosen solution to this problem?
Please check if the PR fulfills these requirements
yarn changeset
to a request a release from the CI if wanted.[ ] This PR introduces a breaking change