feat(ARCH-737/scripts): add jsx file extension support #5256

jmfrancois · 2024-04-05T09:33:34Z

What is the problem this PR is trying to solve?

We are in the process to make our code base support mainstream tools like vite.
We have identified vite by default wants filename extension to be .jsx when the file has react syntax which make sens.

What is the chosen solution to this problem?

Add that to our talend-scripts default configuraiton

We have changed the playground to use jsx and it works !

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2024-04-05T09:38:59Z

5256

Demo is available here

github-actions · 2024-04-05T09:45:36Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.2% (1272/1426)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	90.8% (5513/6071)	81.82% (3188/3896)	88.19% (1390/1576)
containers	83.71% (1388/1658)	74.81% (692/925)	75.17% (327/435)
dataviz	85.44% (323/378)	66.66% (160/240)	75.79% (119/157)
design-system	66.88% (1002/1498)	50.38% (527/1046)	54.54% (216/396)
faceted-search	85.69% (677/790)	79.31% (303/382)	82.63% (238/288)
flow-designer	70.07% (651/929)	66.72% (355/532)	70.92% (200/282)
forms	85.4% (1627/1905)	75.53% (920/1218)	84.22% (459/545)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (73/73)	90.9% (10/11)	100% (24/24)

github-actions · 2024-04-05T09:48:29Z

Size Change: 0 B

Total Size: 17.5 MB

ℹ️ View Unchanged

Filename	Size
`./packages/assets-api/dist/TalendAssetsApi.js`	7.15 kB
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.33 kB
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	277 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	595 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	54.6 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	614 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	163 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	12.8 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB
`./packages/cmf/dist/TalendReactCmf.js`	806 kB
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB
`./packages/cmf/dist/TalendReactCmf.min.js`	151 kB
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB
`./packages/components/dist/TalendReactComponents.css`	397 kB
`./packages/components/dist/TalendReactComponents.js`	4.85 MB
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.21 kB
`./packages/components/dist/TalendReactComponents.min.css`	212 kB
`./packages/components/dist/TalendReactComponents.min.js`	1.29 MB
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.29 kB
`./packages/containers/dist/TalendReactContainers.css`	2.99 kB
`./packages/containers/dist/TalendReactContainers.js`	706 kB
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.4 kB
`./packages/containers/dist/TalendReactContainers.min.css`	1.78 kB
`./packages/containers/dist/TalendReactContainers.min.js`	136 kB
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.45 kB
`./packages/dataviz/dist/TalendReactDataviz.css`	28.1 kB
`./packages/dataviz/dist/TalendReactDataviz.js`	370 kB
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12.2 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js`	59.5 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.19 kB
`./packages/design-system/dist/TalendDesignSystem.css`	321 kB
`./packages/design-system/dist/TalendDesignSystem.js`	1.43 MB
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.49 kB
`./packages/design-system/dist/TalendDesignSystem.min.css`	203 kB
`./packages/design-system/dist/TalendDesignSystem.min.js`	288 kB
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.53 kB
`./packages/design-tokens/dist/TalendDesignTokens.css`	67.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.7 kB
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	63.4 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.4 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	19.1 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	751 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.54 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	6.28 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	148 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.59 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	50.7 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB
`./packages/forms/dist/TalendReactForms.css`	19.7 kB
`./packages/forms/dist/TalendReactForms.js`	902 kB
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.36 kB
`./packages/forms/dist/TalendReactForms.min.css`	6.13 kB
`./packages/forms/dist/TalendReactForms.min.js`	228 kB
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.39 kB
`./packages/http/dist/TalendHttp.js`	24.8 kB
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B
`./packages/http/dist/TalendHttp.min.js`	5.31 kB
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B
`./packages/icons/dist/bundle.js`	1.26 kB
`./packages/icons/dist/info.js`	26.8 kB
`./packages/icons/dist/react.esm.js`	614 kB
`./packages/icons/dist/react.js`	654 kB
`./packages/icons/dist/talend-icons-webfont.css`	18.3 kB
`./packages/icons/dist/talendicons.css`	334 B
`./packages/icons/dist/TalendIcons.js`	786 kB
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B
`./packages/icons/dist/TalendIcons.min.js`	636 kB
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B
`./packages/icons/dist/typeUtils.js`	14.5 kB
`./packages/jsfc/dist/index.js`	86.3 kB
`./packages/jsfc/dist/index.js.dependencies.json`	2 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	134 kB
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	21 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B
`./packages/stepper/dist/TalendReactStepper.css`	2.41 kB
`./packages/stepper/dist/TalendReactStepper.js`	97 kB
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB
`./packages/stepper/dist/TalendReactStepper.min.css`	1.2 kB
`./packages/stepper/dist/TalendReactStepper.min.js`	9.37 kB
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.31 kB
`./packages/storybook-docs/dist/globalStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	384 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.5 kB
`./packages/theme/dist/bootstrap.css`	171 kB
`./packages/theme/dist/bootstrap.js`	2.51 kB
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B

_{compressed-size-action}

…-support

.changeset/fuzzy-seas-stare.md

packages/playground/package.json

.changeset/fuzzy-seas-stare.md

packages/playground/package.json

…-support

feat(scripts): add jsx file extension support

e230ac6

jmfrancois temporarily deployed to pull_request_unsafe April 5, 2024 09:33 — with GitHub Actions Inactive

jmfrancois added 2 commits April 8, 2024 11:48

Merge branch 'master' into jmfrancois/feat/scripts-webpack-config-jsx…

d29070e

…-support

chore: reduce the noise

866edf4

jmfrancois temporarily deployed to pull_request_unsafe April 8, 2024 12:23 — with GitHub Actions Inactive

jmfrancois changed the title ~~feat(scripts): add jsx file extension support~~ feat(ARCH-737/scripts): add jsx file extension support Apr 9, 2024

jmfrancois added 3 commits April 9, 2024 13:32

chore: cleanup

e2f0e95

fix: add version resolution of ace-builds

b80b608

chore: cleanup

1a38198

jmfrancois temporarily deployed to pull_request_unsafe April 9, 2024 12:10 — with GitHub Actions Inactive

jmfrancois marked this pull request as ready for review April 10, 2024 16:06

jmfrancois added the need review label Apr 10, 2024

smouillour reviewed Apr 11, 2024

View reviewed changes

.changeset/fuzzy-seas-stare.md Outdated Show resolved Hide resolved

packages/playground/package.json Outdated Show resolved Hide resolved

jmfrancois commented Apr 12, 2024

View reviewed changes

.changeset/fuzzy-seas-stare.md Outdated Show resolved Hide resolved

Update .changeset/fuzzy-seas-stare.md

bfde785

jmfrancois temporarily deployed to pull_request_unsafe April 12, 2024 07:52 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe April 12, 2024 07:52 — with GitHub Actions Error

jmfrancois commented Apr 12, 2024

View reviewed changes

packages/playground/package.json Outdated Show resolved Hide resolved

Update packages/playground/package.json

1f8a7f2

jmfrancois temporarily deployed to pull_request_unsafe April 12, 2024 07:52 — with GitHub Actions Inactive

jmfrancois temporarily deployed to pull_request_unsafe April 12, 2024 07:53 — with GitHub Actions Inactive

smouillour approved these changes Apr 12, 2024

View reviewed changes

romainseb approved these changes Apr 12, 2024

View reviewed changes

mhuchet approved these changes Apr 12, 2024

View reviewed changes

Merge branch 'master' into jmfrancois/feat/scripts-webpack-config-jsx…

43daa1b

…-support

smouillour temporarily deployed to pull_request_unsafe April 12, 2024 08:49 — with GitHub Actions Inactive

smouillour enabled auto-merge (squash) April 12, 2024 08:54

smouillour merged commit 8c34fb1 into master Apr 12, 2024
13 checks passed

smouillour deleted the jmfrancois/feat/scripts-webpack-config-jsx-support branch April 12, 2024 09:00

smouillour had a problem deploying to pull_request_unsafe April 12, 2024 09:00 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ARCH-737/scripts): add jsx file extension support #5256

feat(ARCH-737/scripts): add jsx file extension support #5256

jmfrancois commented Apr 5, 2024 •

edited

Loading

github-actions bot commented Apr 5, 2024

github-actions bot commented Apr 5, 2024 •

edited

Loading

github-actions bot commented Apr 5, 2024 •

edited

Loading

feat(ARCH-737/scripts): add jsx file extension support #5256

feat(ARCH-737/scripts): add jsx file extension support #5256

Conversation

jmfrancois commented Apr 5, 2024 • edited Loading

github-actions bot commented Apr 5, 2024

github-actions bot commented Apr 5, 2024 • edited Loading

github-actions bot commented Apr 5, 2024 • edited Loading

jmfrancois commented Apr 5, 2024 •

edited

Loading

github-actions bot commented Apr 5, 2024 •

edited

Loading

github-actions bot commented Apr 5, 2024 •

edited

Loading