-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(): status comp - add date-test attr #5244
Merged
jmainguytalend
merged 1 commit into
master
from
jmainguy/chore/status-comp-add-data-test-attr
Mar 27, 2024
Merged
chore(): status comp - add date-test attr #5244
jmainguytalend
merged 1 commit into
master
from
jmainguy/chore/status-comp-add-data-test-attr
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmainguytalend
temporarily deployed
to
pull_request_unsafe
March 27, 2024 14:08
— with
GitHub Actions
Inactive
jmainguytalend
temporarily deployed
to
pull_request_unsafe
March 27, 2024 14:08
— with
GitHub Actions
Inactive
jmainguytalend
temporarily deployed
to
pull_request_unsafe
March 27, 2024 14:08
— with
GitHub Actions
Inactive
jmainguytalend
temporarily deployed
to
pull_request_unsafe
March 27, 2024 14:08
— with
GitHub Actions
Inactive
mhuchet
approved these changes
Mar 27, 2024
Size Change: +1 B (0%) Total Size: 17.5 MB ℹ️ View Unchanged
|
Gbacc
approved these changes
Mar 27, 2024
jmainguytalend
deleted the
jmainguy/chore/status-comp-add-data-test-attr
branch
March 27, 2024 15:19
jmainguytalend
had a problem deploying
to
pull_request_unsafe
March 27, 2024 15:19
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
No data-test* attributes allowed on Status components.
What is the chosen solution to this problem?
Add them in available props and pass it to components.
Please check if the PR fulfills these requirements
yarn changeset
to a request a release from the CI if wanted.[ ] This PR introduces a breaking change