Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump date-fns to 3.X #5080

Merged
merged 6 commits into from
Dec 20, 2023
Merged

deps: bump date-fns to 3.X #5080

merged 6 commits into from
Dec 20, 2023

Conversation

romainseb
Copy link
Contributor

@romainseb romainseb commented Dec 19, 2023 •
edited
Loading

Date FNS 3.X Changelog :
https://github.com/date-fns/date-fns/releases/tag/v3.0.0

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@romainseb romainseb self-assigned this Dec 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

5080

:octocat: Demo is available here

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023 •
edited
Loading

Size Change: +78 kB (0%)

Total Size: 16.7 MB

Filename Size Change
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 184 kB -25.4 kB (-12%) 👏
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 39.4 kB +398 B (+1%)
./packages/cmf/dist/TalendReactCmf.js 714 kB -25.4 kB (-3%)
./packages/cmf/dist/TalendReactCmf.min.js 137 kB +850 B (+1%)
./packages/components/dist/TalendReactComponents.js 4.78 MB +75.8 kB (+2%)
./packages/components/dist/TalendReactComponents.min.js 1.28 MB +2.26 kB (0%)
./packages/containers/dist/TalendReactContainers.js 614 kB -25.4 kB (-4%)
./packages/containers/dist/TalendReactContainers.min.js 122 kB +914 B (+1%)
./packages/dataviz/dist/TalendReactDataviz.js 370 kB -2.69 kB (-1%)
./packages/dataviz/dist/TalendReactDataviz.min.js 59.9 kB -3.45 kB (-5%) ✅
./packages/design-system/dist/TalendDesignSystem.js 1.3 MB -25.4 kB (-2%)
./packages/design-system/dist/TalendDesignSystem.min.js 262 kB +850 B (0%)
./packages/faceted-search/dist/TalendReactFacetedSearch.js 664 kB +109 kB (+20%) 🚨
./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json 1.1 kB -259 B (-19%) 👏
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js 139 kB +20.5 kB (+17%) ⚠️
./packages/forms/dist/TalendReactForms.js 850 kB -25.4 kB (-3%)
./packages/forms/dist/TalendReactForms.min.js 221 kB +936 B (0%)
ℹ️ View Unchanged
Filename Size Change
./packages/assets-api/dist/TalendAssetsApi.js 7.15 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json 2 B 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js 3.33 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json 2 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 672 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 695 B 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js 163 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json 1.25 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js 12.8 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json 1.29 kB 0 B
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 1.31 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 1.35 kB 0 B
./packages/components/dist/TalendReactComponents.css 408 kB 0 B
./packages/components/dist/TalendReactComponents.js.dependencies.json 3.21 kB 0 B
./packages/components/dist/TalendReactComponents.min.css 215 kB 0 B
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 3.29 kB 0 B
./packages/containers/dist/TalendReactContainers.css 3.67 kB 0 B
./packages/containers/dist/TalendReactContainers.js.dependencies.json 1.4 kB 0 B
./packages/containers/dist/TalendReactContainers.min.css 2.34 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 1.45 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.css 28.9 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json 1.15 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.css 12 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json 1.19 kB 0 B
./packages/design-system/dist/TalendDesignSystem.css 313 kB 0 B
./packages/design-system/dist/TalendDesignSystem.js.dependencies.json 1.57 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.css 198 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json 1.61 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.css 65.8 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js 39.6 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json 2 B 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.css 61.7 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js 33.3 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json 2 B 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.css 37.5 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.css 16.8 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json 1.4 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js 50.8 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json 1.25 kB 0 B
./packages/forms/dist/TalendReactForms.css 37.3 kB 0 B
./packages/forms/dist/TalendReactForms.js.dependencies.json 1.35 kB 0 B
./packages/forms/dist/TalendReactForms.min.css 12.5 kB 0 B
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 1.39 kB 0 B
./packages/http/dist/TalendHttp.js 24.8 kB 0 B
./packages/http/dist/TalendHttp.js.dependencies.json 2 B 0 B
./packages/http/dist/TalendHttp.min.js 5.31 kB 0 B
./packages/http/dist/TalendHttp.min.js.dependencies.json 2 B 0 B
./packages/icons/dist/bundle.js 1.26 kB 0 B
./packages/icons/dist/info.js 26.1 kB 0 B
./packages/icons/dist/react.esm.js 585 kB 0 B
./packages/icons/dist/react.js 623 kB 0 B
./packages/icons/dist/talend-icons-webfont.css 17.4 kB 0 B
./packages/icons/dist/talendicons.css 334 B 0 B
./packages/icons/dist/TalendIcons.js 752 kB 0 B
./packages/icons/dist/TalendIcons.js.dependencies.json 128 B 0 B
./packages/icons/dist/TalendIcons.min.js 606 kB 0 B
./packages/icons/dist/TalendIcons.min.js.dependencies.json 131 B 0 B
./packages/icons/dist/typeUtils.js 14.4 kB 0 B
./packages/jsfc/dist/index.js 86.3 kB 0 B
./packages/jsfc/dist/index.js.dependencies.json 2 B 0 B
./packages/router-bridge/dist/TalendRouterBridge.js 134 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json 1.05 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js 21 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json 1.07 kB 0 B
./packages/sagas/dist/TalendReactSagas.js 10.9 kB 0 B
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 348 B 0 B
./packages/sagas/dist/TalendReactSagas.min.js 1.41 kB 0 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 360 B 0 B
./packages/stepper/dist/TalendReactStepper.css 2.4 kB 0 B
./packages/stepper/dist/TalendReactStepper.js 97 kB 0 B
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 1.27 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.css 1.19 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js 9.38 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 1.31 kB 0 B
./packages/storybook-docs/dist/globalStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/globalStyles.min.css 398 B 0 B
./packages/storybook-docs/dist/managerStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/managerStyles.min.css 1.53 kB 0 B
./packages/theme/dist/bootstrap.css 172 kB 0 B
./packages/theme/dist/bootstrap.js 2.51 kB 0 B
./packages/theme/dist/bootstrap.js.dependencies.json 3 B 0 B

compressed-size-action

romainseb
romainseb commented Dec 20, 2023
View reviewed changes
yarn.lock
resolved "https://registry.yarnpkg.com/date-fns/-/date-fns-3.0.1.tgz#a95b3e8296e72cf57c99819f37679aa27ca65ec4"
integrity sha512-cr9igCUa0QSqgAMj7JOrYTY6Nh1rmyGrFDko7ADqfmaQqP/I2N4rlfrLl7AWuzDaoIpz6MNjoEcTPzgZYIrhnA==

date-fns@^2.30.0:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is still used by concurrently on the dev dep side

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023 •
edited
Loading

Title Lines Statements Branches Functions
assets-api Coverage: 28%
 28.4% (25/88) 30.76% (16/52) 21.42% (3/14)
cmf Coverage: 89%
 89.2% (1272/1426) 80.36% (618/769) 88.91% (361/406)
cmf-cqrs Coverage: 87%
 87.43% (160/183) 70.23% (59/84) 84.21% (48/57)
cmf-router Coverage: 70%
 69.23% (135/195) 55.71% (78/140) 56.81% (25/44)
components Coverage: 90%
 90.7% (5591/6164) 81.67% (3231/3956) 88.29% (1410/1597)
containers Coverage: 84%
 83.71% (1388/1658) 74.81% (692/925) 75.17% (327/435)
dataviz Coverage: 85%
 85.6% (321/375) 66.66% (160/240) 75.64% (118/156)
design-system Coverage: 67%
 66.54% (899/1351) 48.56% (440/906) 53.18% (192/361)
faceted-search Coverage: 85%
 84.8% (703/829) 77.8% (284/365) 81.33% (244/300)
flow-designer Coverage: 70%
 70.07% (651/929) 66.72% (355/532) 70.92% (200/282)
forms Coverage: 85%
 85.64% (1676/1957) 75.2% (913/1214) 84.4% (471/558)
http Coverage: 100%
 100% (85/85) 98.07% (51/52) 100% (34/34)
sagas Coverage: 92%
 92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 80%
 81.52% (150/184) 59.34% (54/91) 80.85% (38/47)
utils Coverage: 100%
 100% (70/70) 90.9% (10/11) 100% (22/22)

Gbacc
Gbacc reviewed Dec 20, 2023
View reviewed changes
packages/utils/src/date/date.test.ts Outdated
@@ -125,7 +126,7 @@ describe('date', () => {
expect(localDate).toEqual('2020-05-14T01:00:00+0500');
});

it('should not change timezone tokens that are wrapped in hooks', () => {
it.only('should not change timezone tokens that are wrapped in hooks', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove only

aamalric-talend
aamalric-talend approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@aamalric-talend aamalric-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (watch out Geoffroy comment)

@romainseb romainseb merged commit 922e3eb into master Dec 20, 2023
11 checks passed
@romainseb romainseb deleted the sromain/feat/bump-date-fns branch December 20, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gbacc Gbacc Gbacc approved these changes

@mhuchet mhuchet mhuchet approved these changes

@aamalric-talend aamalric-talend aamalric-talend approved these changes

Assignees

@romainseb romainseb

Labels
need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romainseb @Gbacc @mhuchet @aamalric-talend