fix(TDOPS-4938): force windows to use a shell #4832

lmaillet · 2023-08-02T15:16:26Z

What is the problem this PR is trying to solve?
Since TMC is a monorepo, it's not possible to build it on windows.
See https://jira.talendforge.org/browse/TDOPS-4938

What is the chosen solution to this problem?
Add shell: true in the options of the spawn command when using windows to force the use of a shell.

See: https://nodejs.org/api/child_process.html#child_processspawncommand-args-options

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2023-08-02T15:43:06Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.17% (1268/1422)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	89.98% (5597/6220)	81.09% (3208/3956)	86.98% (1417/1629)
containers	83.53% (1385/1658)	74.67% (687/920)	75.17% (327/435)
dataviz	85.6% (321/375)	66.66% (160/240)	75.64% (118/156)
faceted-search	84.47% (653/773)	76.62% (259/338)	80.86% (224/277)
flow-designer	69.84% (651/932)	66.47% (355/534)	70.67% (200/283)
forms	86.91% (1701/1957)	76.63% (912/1190)	85.86% (480/559)
http	98.76% (80/81)	98% (49/50)	96.77% (30/31)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	91.76% (78/85)	81.39% (35/43)	95.83% (23/24)
utils	100% (64/64)	88.88% (8/9)	100% (15/15)

github-actions · 2023-08-02T15:43:16Z

4832

Demo is available here

github-actions · 2023-08-02T15:44:32Z

Size Change: 0 B

Total Size: 13 MB

ℹ️ View Unchanged

Filename	Size
`./packages/assets-api/dist/TalendAssetsApi.js`	7.21 kB
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.34 kB
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	103 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	672 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	21.4 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	695 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	163 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	13.9 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB
`./packages/cmf/dist/TalendReactCmf.js`	635 kB
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB
`./packages/cmf/dist/TalendReactCmf.min.js`	122 kB
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB
`./packages/components/dist/TalendReactComponents.css`	400 kB
`./packages/components/dist/TalendReactComponents.js`	2.94 MB
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.47 kB
`./packages/components/dist/TalendReactComponents.min.css`	209 kB
`./packages/components/dist/TalendReactComponents.min.js`	636 kB
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.55 kB
`./packages/containers/dist/TalendReactContainers.css`	3.01 kB
`./packages/containers/dist/TalendReactContainers.js`	538 kB
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.55 kB
`./packages/containers/dist/TalendReactContainers.min.css`	1.73 kB
`./packages/containers/dist/TalendReactContainers.min.js`	106 kB
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.6 kB
`./packages/dataviz/dist/TalendReactDataviz.css`	28.9 kB
`./packages/dataviz/dist/TalendReactDataviz.js`	371 kB
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js`	64.6 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.19 kB
`./packages/design-system/dist/TalendDesignSystem.css`	281 kB
`./packages/design-system/dist/TalendDesignSystem.js`	1.07 MB
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.3 kB
`./packages/design-system/dist/TalendDesignSystem.min.css`	172 kB
`./packages/design-system/dist/TalendDesignSystem.min.js`	211 kB
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.33 kB
`./packages/design-tokens/dist/TalendDesignTokens.css`	44.5 kB
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.5 kB
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	41.4 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.2 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	35.5 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	436 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.51 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	16 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	99.4 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.55 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	52.7 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB
`./packages/forms/dist/TalendReactForms.css`	39.3 kB
`./packages/forms/dist/TalendReactForms.js`	778 kB
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.5 kB
`./packages/forms/dist/TalendReactForms.min.css`	13.4 kB
`./packages/forms/dist/TalendReactForms.min.js`	206 kB
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.54 kB
`./packages/http/dist/TalendHttp.js`	24.5 kB
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B
`./packages/http/dist/TalendHttp.min.js`	5.19 kB
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B
`./packages/icons/dist/bundle.js`	1.26 kB
`./packages/icons/dist/info.js`	26.1 kB
`./packages/icons/dist/react.esm.js`	569 kB
`./packages/icons/dist/react.js`	606 kB
`./packages/icons/dist/talend-icons-webfont.css`	17.3 kB
`./packages/icons/dist/talendicons.css`	334 B
`./packages/icons/dist/TalendIcons.js`	733 kB
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B
`./packages/icons/dist/TalendIcons.min.js`	591 kB
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B
`./packages/icons/dist/typeUtils.js`	14.4 kB
`./packages/jsfc/dist/index.js`	86.8 kB
`./packages/jsfc/dist/index.js.dependencies.json`	2 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	133 kB
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	22 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B
`./packages/stepper/dist/TalendReactStepper.js`	24.4 kB
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	945 B
`./packages/stepper/dist/TalendReactStepper.min.js`	4.04 kB
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	971 B
`./packages/storybook-docs/dist/globalStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	10.2 kB
`./packages/storybook-docs/dist/managerStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.53 kB
`./packages/theme/dist/bootstrap.css`	171 kB
`./packages/theme/dist/bootstrap.js`	2.51 kB
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B

_{compressed-size-action}

TDOPS-4938: force windows to use a shell

90c3608

lmaillet temporarily deployed to pull_request_unsafe August 2, 2023 15:16 — with GitHub Actions Inactive

lmaillet had a problem deploying to pull_request_unsafe August 2, 2023 15:16 — with GitHub Actions Error

changeset'

35d638a

lmaillet temporarily deployed to pull_request_unsafe August 2, 2023 15:18 — with GitHub Actions Inactive

ybaskaran approved these changes Aug 2, 2023

View reviewed changes

smouillour approved these changes Aug 3, 2023

View reviewed changes

lmaillet merged commit d9616e4 into master Aug 3, 2023
8 checks passed

lmaillet deleted the lmaillet/fix/tdops-4938-build-on-windows branch August 3, 2023 07:47

lmaillet temporarily deployed to pull_request_unsafe August 3, 2023 07:47 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(TDOPS-4938): force windows to use a shell #4832

fix(TDOPS-4938): force windows to use a shell #4832

lmaillet commented Aug 2, 2023 •

edited

Loading

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

fix(TDOPS-4938): force windows to use a shell #4832

fix(TDOPS-4938): force windows to use a shell #4832

Conversation

lmaillet commented Aug 2, 2023 • edited Loading

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

lmaillet commented Aug 2, 2023 •

edited

Loading