Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TDOPS-4851): No copied message when switching back #4825

Merged
merged 9 commits into from
Aug 4, 2023
Merged

fix(TDOPS-4851): No copied message when switching back #4825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
52afe7c
fix(TDOPS-4851): No copied message when switching back
hbhong Jul 31, 2023
c07dee4
Merge branch 'master' into hbhong/fix/TDOPS-4851-no-copy-message
hbhong Jul 31, 2023
e349b32
Merge branch 'master' into hbhong/fix/TDOPS-4851-no-copy-message
hbhong Aug 1, 2023
688b780
Merge branch 'master' into hbhong/fix/TDOPS-4851-no-copy-message
hbhong Aug 2, 2023
3491bf8
Merge branch 'master' into hbhong/fix/TDOPS-4851-no-copy-message
hbhong Aug 4, 2023
e518d4b
fix(TDOPS-4851): No copied message when switching back
hbhong Aug 4, 2023
446905e
remove changeset
hbhong Aug 4, 2023
2c0ffd6
change to patch
hbhong Aug 4, 2023
a13cb84
rename "inputValue" to "value"
hbhong Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pretty-yaks-joke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@talend/design-system': patch
---

Form.Copy - Fix no copied message after switching back
8 changes: 6 additions & 2 deletions packages/design-system/src/components/Form/Field/Input/Input.Copy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,11 @@
}
return '';
};

const doCopy = () => {
const value = inputRef.current?.value || '';

Check warning on line 67 in packages/design-system/src/components/Form/Field/Input/Input.Copy.tsx

View workflow job for this annotation

GitHub Actions / ESLint Report Analysis

packages/design-system/src/components/Form/Field/Input/Input.Copy.tsx#L67 

[@typescript-eslint/no-shadow] 'value' is already declared in the upper scope on line 24 column 4.
copyToClipboard(value);
setCopiedValue(value);
};
return (
<FieldPrimitive
label={label}
Expand All @@ -83,7 +87,7 @@
suffix={{
type: 'button',
icon: 'talend-files-o',
onClick: () => copyToClipboard(inputRef.current?.value || ''),
onClick: doCopy,
disabled: !!disabled || !!readOnly,
children: t('FORM_COPY_COPY_TO_CLIPBOARD', 'Copy to clipboard'),
hideText: true,
Expand Down
Loading