fix(TDOPS-4682): Fix design system form file to integrate on TMC #4800

Gbacc · 2023-07-13T12:19:04Z

What is the problem this PR is trying to solve?
Fix design system form file to integrate on TMC

files prop to be taken into account when changing
on file clear, trigger onChange event

What is the chosen solution to this problem?

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2023-07-13T12:49:45Z

4800

Demo is available here

github-actions · 2023-07-13T12:53:05Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.17% (1268/1422)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	89.99% (5602/6225)	81.17% (3199/3941)	86.98% (1417/1629)
containers	83.53% (1385/1658)	74.67% (687/920)	75.17% (327/435)
dataviz	85.37% (321/376)	66.66% (160/240)	75.64% (118/156)
faceted-search	84.47% (653/773)	76.62% (259/338)	80.86% (224/277)
flow-designer	69.84% (651/932)	66.47% (355/534)	70.67% (200/283)
forms	86.52% (1695/1959)	76.27% (910/1193)	85.66% (478/558)
http	98.76% (80/81)	98% (49/50)	96.77% (30/31)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	91.76% (78/85)	81.39% (35/43)	95.83% (23/24)
utils	100% (64/64)	88.88% (8/9)	100% (15/15)

github-actions · 2023-07-13T12:54:04Z

Size Change: +252 B (0%)

Total Size: 13 MB

Filename	Size	Change
`./packages/design-system/dist/TalendDesignSystem.js`	1.07 MB	+169 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
`./packages/assets-api/dist/TalendAssetsApi.js`	7.21 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.34 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	103 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	672 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	21.4 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	695 B	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	163 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	13.9 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js`	635 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js`	122 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB	0 B
`./packages/components/dist/TalendReactComponents.css`	373 kB	0 B
`./packages/components/dist/TalendReactComponents.js`	2.94 MB	0 B
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.28 kB	0 B
`./packages/components/dist/TalendReactComponents.min.css`	194 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js`	636 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.36 kB	0 B
`./packages/containers/dist/TalendReactContainers.css`	2.93 kB	0 B
`./packages/containers/dist/TalendReactContainers.js`	538 kB	0 B
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.55 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.css`	1.73 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js`	106 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.6 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.css`	25.9 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js`	371 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.css`	10.1 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js`	64.4 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.19 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.css`	275 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.3 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.css`	166 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js`	211 kB	+83 B (0%)
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.33 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.css`	38.5 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js`	34.5 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	35.7 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	28.4 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	33.8 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	436 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.51 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	15.5 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	99.5 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.55 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	52.7 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB	0 B
`./packages/forms/dist/mode-json.js`	48.3 kB	0 B
`./packages/forms/dist/mode-python.js`	4.58 kB	0 B
`./packages/forms/dist/mode-sql.js`	1.83 kB	0 B
`./packages/forms/dist/snippets-json.js`	131 B	0 B
`./packages/forms/dist/snippets-python.js`	3.84 kB	0 B
`./packages/forms/dist/snippets-sql.js`	972 B	0 B
`./packages/forms/dist/TalendReactForms.css`	36.7 kB	0 B
`./packages/forms/dist/TalendReactForms.js`	778 kB	0 B
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.5 kB	0 B
`./packages/forms/dist/TalendReactForms.min.css`	12.4 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js`	206 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.54 kB	0 B
`./packages/forms/dist/theme-chrome.js`	2.71 kB	0 B
`./packages/http/dist/TalendHttp.js`	24.5 kB	0 B
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B	0 B
`./packages/http/dist/TalendHttp.min.js`	5.19 kB	0 B
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B	0 B
`./packages/icons/dist/bundle.js`	1.26 kB	0 B
`./packages/icons/dist/info.js`	26.1 kB	0 B
`./packages/icons/dist/react.esm.js`	569 kB	0 B
`./packages/icons/dist/react.js`	606 kB	0 B
`./packages/icons/dist/talend-icons-webfont.css`	17.3 kB	0 B
`./packages/icons/dist/talendicons.css`	334 B	0 B
`./packages/icons/dist/TalendIcons.js`	733 kB	0 B
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B	0 B
`./packages/icons/dist/TalendIcons.min.js`	591 kB	0 B
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B	0 B
`./packages/icons/dist/typeUtils.js`	14.4 kB	0 B
`./packages/jsfc/dist/index.js`	86.8 kB	0 B
`./packages/jsfc/dist/index.js.dependencies.json`	2 B	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	133 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	22 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B	0 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB	0 B
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B	0 B
`./packages/stepper/dist/TalendReactStepper.js`	24.4 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	945 B	0 B
`./packages/stepper/dist/TalendReactStepper.min.js`	4.04 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	971 B	0 B
`./packages/storybook-docs/dist/globalStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	10.2 kB	0 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.53 kB	0 B
`./packages/theme/dist/bootstrap.css`	149 kB	0 B
`./packages/theme/dist/bootstrap.js`	2.51 kB	0 B
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B	0 B

_{compressed-size-action}

jmfrancois

add test case please

Gbacc · 2023-07-17T13:24:36Z

add test case please

Good point , created a test for it now

Gbacc had a problem deploying to pull_request_unsafe July 13, 2023 12:19 — with GitHub Actions Error

Gbacc temporarily deployed to pull_request_unsafe July 13, 2023 12:19 — with GitHub Actions Inactive

Gbacc had a problem deploying to pull_request_unsafe July 13, 2023 12:19 — with GitHub Actions Error

fix(TDOPS-4682): Fix design system form file to integrate on TMC

2717488

Gbacc force-pushed the gbacc/fix/TDOPS-4682-input-file-fixes branch from f4bdeff to 2717488 Compare July 13, 2023 12:30

Gbacc temporarily deployed to pull_request_unsafe July 13, 2023 12:30 — with GitHub Actions Inactive

jmfrancois requested changes Jul 13, 2023

View reviewed changes

added tests

f891b25

Gbacc temporarily deployed to pull_request_unsafe July 17, 2023 13:23 — with GitHub Actions Inactive

Gbacc had a problem deploying to pull_request_unsafe July 17, 2023 13:23 — with GitHub Actions Error

Merge branch 'master' into gbacc/fix/TDOPS-4682-input-file-fixes

23638fb

Gbacc temporarily deployed to pull_request_unsafe July 17, 2023 13:24 — with GitHub Actions Inactive

romainseb approved these changes Jul 18, 2023

View reviewed changes

Gbacc requested a review from jmfrancois July 18, 2023 08:11

jmainguytalend approved these changes Jul 18, 2023

View reviewed changes

Merge branch 'master' into gbacc/fix/TDOPS-4682-input-file-fixes

7342c49

Gbacc temporarily deployed to pull_request_unsafe July 18, 2023 08:54 — with GitHub Actions Inactive

jmfrancois approved these changes Jul 18, 2023

View reviewed changes

Gbacc merged commit 0789cda into master Jul 18, 2023
10 checks passed

Gbacc deleted the gbacc/fix/TDOPS-4682-input-file-fixes branch July 18, 2023 09:43

Gbacc temporarily deployed to pull_request_unsafe July 18, 2023 09:43 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(TDOPS-4682): Fix design system form file to integrate on TMC #4800

fix(TDOPS-4682): Fix design system form file to integrate on TMC #4800

Gbacc commented Jul 13, 2023 •

edited

Loading

github-actions bot commented Jul 13, 2023

github-actions bot commented Jul 13, 2023 •

edited

Loading

github-actions bot commented Jul 13, 2023 •

edited

Loading

jmfrancois left a comment

Gbacc commented Jul 17, 2023

fix(TDOPS-4682): Fix design system form file to integrate on TMC #4800

fix(TDOPS-4682): Fix design system form file to integrate on TMC #4800

Conversation

Gbacc commented Jul 13, 2023 • edited Loading

github-actions bot commented Jul 13, 2023

github-actions bot commented Jul 13, 2023 • edited Loading

github-actions bot commented Jul 13, 2023 • edited Loading

jmfrancois left a comment

Choose a reason for hiding this comment

Gbacc commented Jul 17, 2023

Gbacc commented Jul 13, 2023 •

edited

Loading

github-actions bot commented Jul 13, 2023 •

edited

Loading

github-actions bot commented Jul 13, 2023 •

edited

Loading