chore: upgrade date-fns to 2.x and fix #4510

jmfrancois · 2022-12-26T16:25:29Z

What is the problem this PR is trying to solve?

date-fns 1 is really old now.

What is the chosen solution to this problem?

upgrade to date-fns 2
apply breaking changes (mainly import path changes)

TODO:

fix i18n (ERROR: locale must contain localize property)
fix tests

note: date-fns has no UMD, so you can see the impact on the size of our umds.

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2023-01-04T10:48:58Z

Size Change: +10.3 MB (+76%) 🆘

Total Size: 23.7 MB

Filename	Size	Change
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	1.15 MB	+1.05 MB (+1022%)	🆘
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	121 kB	+99.9 kB (+468%)	🆘
`./packages/cmf/dist/TalendReactCmf.js`	1.69 MB	+1.06 MB (+166%)	🆘
`./packages/cmf/dist/TalendReactCmf.min.js`	221 kB	+100 kB (+83%)	🆘
`./packages/components/dist/TalendReactComponents.js`	5.58 MB	+2.61 MB (+88%)	🆘
`./packages/components/dist/TalendReactComponents.min.js`	1.37 MB	+710 kB (+107%)	🆘
`./packages/containers/dist/TalendReactContainers.js`	1.59 MB	+1.06 MB (+198%)	🆘
`./packages/containers/dist/TalendReactContainers.min.js`	204 kB	+100 kB (+97%)	🆘
`./packages/dataviz/dist/TalendReactDataviz.js`	373 kB	+1.03 kB (0%)
`./packages/design-system/dist/TalendDesignSystem.js`	2.27 MB	+1.06 MB (+87%)	🆘
`./packages/design-system/dist/TalendDesignSystem.min.js`	343 kB	+100 kB (+41%)	🚨
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	1.5 MB	+1.06 MB (+236%)	🆘
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	201 kB	+101 kB (+100%)	🆘
`./packages/forms/dist/TalendReactForms.js`	1.83 MB	+1.06 MB (+137%)	🆘
`./packages/forms/dist/TalendReactForms.min.js`	304 kB	+100 kB (+49%)	🚨

ℹ️ View Unchanged

Filename	Size
`./packages/assets-api/dist/TalendAssetsApi.js`	7.21 kB
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.34 kB
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	672 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	695 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	164 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	13 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB
`./packages/components/dist/TalendReactComponents.css`	403 kB
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.21 kB
`./packages/components/dist/TalendReactComponents.min.css`	210 kB
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.29 kB
`./packages/containers/dist/TalendReactContainers.css`	3.01 kB
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.55 kB
`./packages/containers/dist/TalendReactContainers.min.css`	1.74 kB
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.6 kB
`./packages/dataviz/dist/TalendReactDataviz.css`	28.9 kB
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js`	63.6 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.19 kB
`./packages/design-system/dist/TalendDesignSystem.css`	288 kB
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.57 kB
`./packages/design-system/dist/TalendDesignSystem.min.css`	175 kB
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.61 kB
`./packages/design-tokens/dist/TalendDesignTokens.css`	44.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	41.5 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.3 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	37.5 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.36 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	16.8 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.4 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	51.5 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB
`./packages/forms/dist/TalendReactForms.css`	37.6 kB
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.35 kB
`./packages/forms/dist/TalendReactForms.min.css`	12.8 kB
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.39 kB
`./packages/http/dist/TalendHttp.js`	24.9 kB
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B
`./packages/http/dist/TalendHttp.min.js`	5.33 kB
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B
`./packages/icons/dist/bundle.js`	1.26 kB
`./packages/icons/dist/info.js`	26.1 kB
`./packages/icons/dist/react.esm.js`	585 kB
`./packages/icons/dist/react.js`	623 kB
`./packages/icons/dist/talend-icons-webfont.css`	17.4 kB
`./packages/icons/dist/talendicons.css`	334 B
`./packages/icons/dist/TalendIcons.js`	752 kB
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B
`./packages/icons/dist/TalendIcons.min.js`	606 kB
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B
`./packages/icons/dist/typeUtils.js`	14.4 kB
`./packages/jsfc/dist/index.js`	86.8 kB
`./packages/jsfc/dist/index.js.dependencies.json`	2 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	134 kB
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	21 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B
`./packages/stepper/dist/TalendReactStepper.css`	2.4 kB
`./packages/stepper/dist/TalendReactStepper.js`	97.4 kB
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB
`./packages/stepper/dist/TalendReactStepper.min.css`	1.19 kB
`./packages/stepper/dist/TalendReactStepper.min.js`	9.64 kB
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.31 kB
`./packages/storybook-docs/dist/globalStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	398 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.53 kB
`./packages/theme/dist/bootstrap.css`	172 kB
`./packages/theme/dist/bootstrap.js`	2.51 kB
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B

_{compressed-size-action}

github-actions · 2023-01-04T10:51:12Z

4510

Demo is available here

github-actions · 2023-12-07T21:09:27Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.2% (1272/1426)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	90.7% (5589/6162)	81.66% (3229/3954)	88.29% (1410/1597)
containers	83.71% (1388/1658)	74.81% (692/925)	75.17% (327/435)
dataviz	85.6% (321/375)	66.66% (160/240)	75.64% (118/156)
design-system	66.54% (899/1351)	48.56% (440/906)	53.18% (192/361)
faceted-search	84.8% (703/829)	77.8% (284/365)	81.33% (244/300)
flow-designer	70.07% (651/929)	66.72% (355/532)	70.92% (200/282)
forms	85.62% (1674/1955)	75.2% (913/1214)	84.4% (471/558)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (70/70)	90.9% (10/11)	100% (22/22)

Gbacc

looks good

jmfrancois temporarily deployed to pull_request_unsafe December 26, 2022 16:25 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe December 26, 2022 16:25 — with GitHub Actions Failure

jmfrancois temporarily deployed to pull_request_unsafe December 26, 2022 16:38 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe December 26, 2022 16:38 — with GitHub Actions Failure

jmfrancois temporarily deployed to pull_request_unsafe December 26, 2022 16:38 — with GitHub Actions Inactive

jmfrancois changed the title ~~chore :upgrade and see~~ chore: upgrade date-fns to 2.x and fix Dec 27, 2022

jmfrancois temporarily deployed to pull_request_unsafe January 4, 2023 10:33 — with GitHub Actions Inactive

romainseb added the help wanted label Nov 28, 2023

romainseb mentioned this pull request Nov 28, 2023

chore(deps): bump date-fns and @types/date-fns #4684

Closed

aamalric-talend force-pushed the jmfrancois/chore/date-fns-2 branch from 572a3e5 to 3ce9c7c Compare November 28, 2023 14:08

aamalric-talend temporarily deployed to pull_request_unsafe November 28, 2023 14:08 — with GitHub Actions Inactive

aamalric-talend had a problem deploying to pull_request_unsafe November 28, 2023 14:08 — with GitHub Actions Failure

jmfrancois and others added 4 commits December 7, 2023 13:57

chore :upgrade and see

5100da7

chore: continue migration

dba1c13

fix: build faceted

09aad90

fix: update tests and upgrade code

16b2a67

aamalric-talend force-pushed the jmfrancois/chore/date-fns-2 branch from 3ce9c7c to 16b2a67 Compare December 7, 2023 20:57

aamalric-talend temporarily deployed to pull_request_unsafe December 7, 2023 20:57 — with GitHub Actions Inactive

aamalric-talend self-assigned this Dec 7, 2023

aamalric-talend added work in progress and removed help wanted labels Dec 7, 2023

aamalric-talend marked this pull request as ready for review December 7, 2023 21:13

Add changeset

6dcdb56

aamalric-talend temporarily deployed to pull_request_unsafe December 8, 2023 08:11 — with GitHub Actions Inactive

aamalric-talend added need review and removed work in progress labels Dec 8, 2023

Gbacc approved these changes Dec 8, 2023

View reviewed changes

jmainguytalend approved these changes Dec 8, 2023

View reviewed changes

romainseb approved these changes Dec 8, 2023

View reviewed changes

aamalric-talend merged commit 424544a into master Dec 8, 2023
12 checks passed

aamalric-talend deleted the jmfrancois/chore/date-fns-2 branch December 8, 2023 15:34

aamalric-talend had a problem deploying to pull_request_unsafe December 8, 2023 15:34 — with GitHub Actions Failure

mhuchet approved these changes Dec 8, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade date-fns to 2.x and fix #4510

chore: upgrade date-fns to 2.x and fix #4510

jmfrancois commented Dec 26, 2022 •

edited by aamalric-talend

Loading

github-actions bot commented Jan 4, 2023 •

edited

Loading

github-actions bot commented Jan 4, 2023

github-actions bot commented Dec 7, 2023 •

edited

Loading

Gbacc left a comment

chore: upgrade date-fns to 2.x and fix #4510

chore: upgrade date-fns to 2.x and fix #4510

Conversation

jmfrancois commented Dec 26, 2022 • edited by aamalric-talend Loading

github-actions bot commented Jan 4, 2023 • edited Loading

github-actions bot commented Jan 4, 2023

github-actions bot commented Dec 7, 2023 • edited Loading

Gbacc left a comment

Choose a reason for hiding this comment

jmfrancois commented Dec 26, 2022 •

edited by aamalric-talend

Loading

github-actions bot commented Jan 4, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading