From 293760b0d9a7bdba4b290aba07a9340c87bd2c7a Mon Sep 17 00:00:00 2001
From: Gbacc <Gbacc@users.noreply.github.com>
Date: Fri, 11 Oct 2024 08:58:40 +0200
Subject: [PATCH] fix(TMC-25993): fix DS textarea row property and static css
 height (#5424)

* fix(TMC-25993): fix DS textarea row property and static css height

* fix tests
---
 .changeset/fuzzy-dancers-move.md                            | 5 +++++
 .../Form/Primitives/Textarea/Textarea.module.scss           | 1 -
 .../src/components/Form/Primitives/Textarea/Textarea.tsx    | 4 ++++
 .../src/components/Form/__snapshots__/Form.test.tsx.snap    | 1 +
 .../stories/form/Field/Textarea/Input.Textarea.stories.tsx  | 6 ++++++
 5 files changed, 16 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/fuzzy-dancers-move.md

diff --git a/.changeset/fuzzy-dancers-move.md b/.changeset/fuzzy-dancers-move.md
new file mode 100644
index 00000000000..16e6cddd5c4
--- /dev/null
+++ b/.changeset/fuzzy-dancers-move.md
@@ -0,0 +1,5 @@
+---
+'@talend/design-system': patch
+---
+
+fix: allow form Textarea to changes number of rows and remove fixed css min-height
diff --git a/packages/design-system/src/components/Form/Primitives/Textarea/Textarea.module.scss b/packages/design-system/src/components/Form/Primitives/Textarea/Textarea.module.scss
index d5162abb077..645430f0a90 100644
--- a/packages/design-system/src/components/Form/Primitives/Textarea/Textarea.module.scss
+++ b/packages/design-system/src/components/Form/Primitives/Textarea/Textarea.module.scss
@@ -4,7 +4,6 @@
 .textarea {
 	@include Form.base-input();
 	@include Form.border-styles();
-	min-height: calc(#{tokens.$coral-sizing-l} * 2);
 	max-height: tokens.$coral-sizing-xxxl;
 	resize: vertical;
 	line-height: 140%;
diff --git a/packages/design-system/src/components/Form/Primitives/Textarea/Textarea.tsx b/packages/design-system/src/components/Form/Primitives/Textarea/Textarea.tsx
index 43f1962389c..fdccc55f350 100644
--- a/packages/design-system/src/components/Form/Primitives/Textarea/Textarea.tsx
+++ b/packages/design-system/src/components/Form/Primitives/Textarea/Textarea.tsx
@@ -1,13 +1,17 @@
 import { forwardRef, Ref, TextareaHTMLAttributes } from 'react';
+
 import classnames from 'classnames';
+
 import styles from './Textarea.module.scss';
 
 export type TextareaPrimitiveProps = TextareaHTMLAttributes<any> & { hasError?: boolean };
 
 const Textarea = forwardRef((props: TextareaPrimitiveProps, ref: Ref<HTMLTextAreaElement>) => {
 	const { className, readOnly = false, disabled = false, hasError = false, ...rest } = props;
+	const defaultRowsNumber = 3;
 	return (
 		<textarea
+			rows={defaultRowsNumber}
 			{...rest}
 			ref={ref}
 			disabled={disabled}
diff --git a/packages/design-system/src/components/Form/__snapshots__/Form.test.tsx.snap b/packages/design-system/src/components/Form/__snapshots__/Form.test.tsx.snap
index 0ee376c907d..4983ba9a137 100644
--- a/packages/design-system/src/components/Form/__snapshots__/Form.test.tsx.snap
+++ b/packages/design-system/src/components/Form/__snapshots__/Form.test.tsx.snap
@@ -233,6 +233,7 @@ exports[`Form should render a11y html 1`] = `
             class="theme-textarea"
             id="field--mocked-uuid-8"
             name="textarea"
+            rows="3"
           />
         </div>
         <div
diff --git a/packages/design-system/src/stories/form/Field/Textarea/Input.Textarea.stories.tsx b/packages/design-system/src/stories/form/Field/Textarea/Input.Textarea.stories.tsx
index 7c5320d8c0f..85829ecea23 100644
--- a/packages/design-system/src/stories/form/Field/Textarea/Input.Textarea.stories.tsx
+++ b/packages/design-system/src/stories/form/Field/Textarea/Input.Textarea.stories.tsx
@@ -43,6 +43,12 @@ export const Textarea = () => (
 			hasError
 			description="There is an error here"
 		/>
+		<Form.Textarea
+			rows={2}
+			placeholder="Placeholder"
+			name="time"
+			label="Textarea with custom number of rows"
+		/>
 	</StackVertical>
 );