Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Audio Playback #450

Open
3 tasks done
AwesomeParley opened this issue Sep 5, 2024 · 7 comments
Open
3 tasks done

[Feature Request]: Audio Playback #450

AwesomeParley opened this issue Sep 5, 2024 · 7 comments
Labels
Type: Enhancement New feature or request

Comments

@AwesomeParley
Copy link

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

Description

Basically the same way that videos have playback when you press on them, audio should also playback. For right now, we have to press on the audio file, then press the icon on the right to open up another app to play the audio, instead, it should just play in the app.

Solution

No response

Alternatives

No response

@AwesomeParley AwesomeParley added the Type: Enhancement New feature or request label Sep 5, 2024
@csponge
Copy link

csponge commented Sep 12, 2024

Hi there!

I'm interested in this feature as well. I'll probably take a crack at implementing it, unless someone else has already done so.

@csponge
Copy link

csponge commented Sep 26, 2024

Just wanted to give an update. I haven't forgotten about this!

I currently have audio files playing. I have a slider to change position, and buttons for play, pause, and mute.

There are a few more minor things to fix, but I'm hoping to have that done relatively soon.

After I get that all working, I think it would be cool to add a queue feature in. Not sure if that makes sense to include in this issue. Any thoughts on that?

@CyanVoxel
Copy link
Member

Just wanted to give an update. I haven't forgotten about this!

I currently have audio files playing. I have a slider to change position, and buttons for play, pause, and mute.

There are a few more minor things to fix, but I'm hoping to have that done relatively soon.

After I get that all working, I think it would be cool to add a queue feature in. Not sure if that makes sense to include in this issue. Any thoughts on that?

That sounds awesome! Not sure about a queue feature though, I feel that's outside the scope of the program. Playing back audio files is great for previewing but queues are more so the territory of a music player in my opinion.

@AwesomeParley
Copy link
Author

Just wanted to give an update. I haven't forgotten about this!

I currently have audio files playing. I have a slider to change position, and buttons for play, pause, and mute.

There are a few more minor things to fix, but I'm hoping to have that done relatively soon.

Awesome! I'm glad that it's being worked on and seems to be working for you.

After I get that all working, I think it would be cool to add a queue feature in. Not sure if that makes sense to include in this issue. Any thoughts on that?

I do agree that would be very cool, but seeing as CyanVoxel thinks it's outside the scope of the project, we can maybe wait a bit before adding that. I do believe it would be useful, but there's a lot of stuff we still have to do that's more important.

Thanks for working on it!

csponge added a commit to csponge/TagStudio that referenced this issue Sep 29, 2024
* Add the ablity to play audio files defined in the AUDIO_TYPES list.

* Add a slider to seek through an audio file.

* Add play/pause and mute/unmute buttons for audio files.

Refs: TagStudioDev#450
@Cool-Game-Gev
Copy link

Is this resolved? If it is, I hate to be that guy, but you should close the issue

@CyanVoxel
Copy link
Member

Is this resolved? If it is, I hate to be that guy, but you should close the issue

There is a linked open pull request related to this issue (#529), and this feature request is not resolved until that or another PR that covers this issue is merged.

@Cool-Game-Gev
Copy link

@CyanVoxel Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

4 participants