Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Style Guide #13

Open
brentleyjones opened this issue Jul 14, 2015 · 4 comments
Open

Add Style Guide #13

brentleyjones opened this issue Jul 14, 2015 · 4 comments
Assignees
Milestone

Comments

@brentleyjones
Copy link
Member

Since I know I'm a stickler about code style we should have a style guide that we can point to when asking people to clean up contributions. A PR can still be merged without following it (if needed, like when a contributor goes silent), but only if someone on @TabletopAssistant/dicekit cleans it up right after.

@brentleyjones
Copy link
Member Author

@TabletopAssistant/dicekit do we feel this is needed for release 0.1?

@JonathanHoffman
Copy link
Contributor

No, since 0.1 was originally defined as everything needed to be used by others. Contributing is not necessary for usage. :)

@brentleyjones
Copy link
Member Author

Good call. This can get in whenever then, which is good, because I would rather get 0.1 and 0.2 out ASAP so I can start talking about the project more broadly... though I might get the style guide done before that because before people contribute I would want this in place (I think).

@LoganJohnson
Copy link
Contributor

Also agreed here. Not needed yet but will be valuable eventually.

@brentleyjones brentleyjones modified the milestone: 1.0 Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants