Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug in camera transform #164

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Conversation

chrisochoatri
Copy link
Collaborator

@chrisochoatri chrisochoatri commented Jun 11, 2024

new image height was being calculated incorrectly


This change is Reviewable

@chrisochoatri chrisochoatri changed the title fix: fix bug camera transform fix: fix bug in camera transform Jun 11, 2024
Copy link
Collaborator

@yusuke-kanzawa yusuke-kanzawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@yusuke-kanzawa for Feature Review.

Reviewed 1 of 1 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @chrisochoatri)

Copy link
Collaborator

@yusuke-kanzawa yusuke-kanzawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @chrisochoatri)

@chrisochoatri chrisochoatri merged commit 19ded02 into TRI-ML:master Jun 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants