Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user choose wich wallet to activate Tokenpocket or Metamask #40

Open
moijia opened this issue May 19, 2023 · 3 comments
Open

Allow user choose wich wallet to activate Tokenpocket or Metamask #40

moijia opened this issue May 19, 2023 · 3 comments
Assignees

Comments

@moijia
Copy link

moijia commented May 19, 2023

https://www.sushi.com/swap
sushi_connect

Once tockenpocket extension installed it disable Metamask Wallet

@chendatony31
Copy link
Member

There is a setting for active TokenPocket or Metamask.
image

@octavioamu
Copy link

octavioamu commented Sep 13, 2023

If I have tokenpoket extension enable then metamask will not work as tokenpocket is taking over the provider, this approach should be changed as will force the users to keep this extension disabled

This can be easy tested with the 2 wallets extension installed and enabled on https://www.sushi.com/swap

@chendatony31
Copy link
Member

Hi, @octavioamu @moijia, here is some update about this:

  1. With the TokenPocket extension, you can access window.tokenpocket.ethereum as the provider (mobile wallet will support in the next release).

  2. We have supported EIP-6963 to solve the multi providers's problems (TokenPocket extension and mobile wallets).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@octavioamu @chendatony31 @moijia and others